Re: What about making a release?

On Mon, 20 Jan 2014 16:01:15 +0100
Juliusz Chroboczek <[email protected]> wrote:

> > You might want to take a look at my github repository as it
> > incorporates uncommitted patches, mainly from the mailing list and
> > various forks on github.
> 
> : Add a maybe state to mindlesslyCacheVary.
> 
> Perhaps I misunderstand, but at first sight it's wrong.
> 
> : The log max is 0XFFFFFF not 0XFF
> 
> This one is certainly incorrect.  LOGGING_MAX is used to disable log
> statements at compile time, and by default it is set to 0xFF so that
> the debug statements are compiled out (see the do_log macro and
> friends).  Setting it to a larger value bloats Polipo a little bit.
> 
> : Adding an autogenerated version for linking a binary to a git revision
> 
> This should be modified to do the right thing when HEAD is at a tag of
> the form polipo-[0-9.]+
> 
> It also uses GNU make extensions ($shell).
> 
> : Give memrchr a reachable termination condition
> 
> Huh?
> 
> -- Juliusz

I'm not really qualified to judge whether a particular commit is good or bad as I'm not a programmer. A lot of patches that people posted to the list in the last year or so weren't reviewed, so I merely collected up a lot of other peoples' stuff and put it in one place for others to cherrypick from.


Jeff

-- 


------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk