Disk cache is not being written since Polipo 1.1.1

[email protected] Wed, 17 Sep 2014 21:25:39 -0300
Newsgroups gmane.comp.web.polipo.user
Message-ID <1410999939.3990672.168802953.5A38880B@webmail.messagingengine.com>
Hello.

I am running Polipo from Git master branch, and realized that the cache
entries are not being written to disk.

I guess the regression has happened on commit:

2005534 - use checkRoot() which also handles WIN32 paths correctly (4
months ago) <xnoreq>

More specifically, in this hunk:

@@ -369,12 +368,7 @@ urlDirname(char *buf, int n, const char *url, int
len)
     if(lwrcmp(url, "http://", 7) != 0)
         return -1;
 
-    if(diskCacheRoot == NULL ||
-       diskCacheRoot->length <= 0
-#ifndef WIN32
-       || diskCacheRoot->string[0] != '/'
-#endif
-       )
+    if(checkRoot(localDocumentRoot) <= 0)
         return -1;
 
     if(n <= diskCacheRoot->length)


I reverted this commit and the problem seems to be gone.

Thanks!

------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk