Re: Disk cache is not being written since Polipo 1.1.1

All,

The relevant patch is essentially 'good', but there's a typo on line 371 of
diskcache.c, which is:
if(checkRoot(localDocumentRoot) <= 0)

It appears to be a cut-and-past typo (from earlier in the file), cause (I
think) it should actually read:
if(checkRoot(*diskCacheRoot*) <= 0)

Thanks for spotting it Crypto!

For my part, if I set *localDocumentRoot *to a valid directory (even though
the folder is empty), then the in-memory cache is written to disk, when
otherwise it is not!

Juliusz/Gabriel: this is the cause/solution of the problem I was having
before with the disk cache from a couple of months ago.

I am sorry, but I don't have the skills to create/submit this patch to
either Git (i.e. Polipo / OpenWrt), Maybe I could leave it to one of you?

In the meantime, I have a workaround!

-Dave

On 18 September 2014 01:25, <[email protected]> wrote:

> Hello.
>
> I am running Polipo from Git master branch, and realized that the cache
> entries are not being written to disk.
>
> I guess the regression has happened on commit:
>
> 2005534 - use checkRoot() which also handles WIN32 paths correctly (4
> months ago) <xnoreq>
>
> More specifically, in this hunk:
>
> @@ -369,12 +368,7 @@ urlDirname(char *buf, int n, const char *url, int
> len)
>      if(lwrcmp(url, "http://", 7) != 0)
>          return -1;
>
> -    if(diskCacheRoot == NULL ||
> -       diskCacheRoot->length <= 0
> -#ifndef WIN32
> -       || diskCacheRoot->string[0] != '/'
> -#endif
> -       )
> +    if(checkRoot(localDocumentRoot) <= 0)
>          return -1;
>
>      if(n <= diskCacheRoot->length)
>
>
> I reverted this commit and the problem seems to be gone.
>
> Thanks!
>
>
> ------------------------------------------------------------------------------
> Want excitement?
> Manually upgrade your production database.
> When you want reliability, choose Perforce
> Perforce version control. Predictably reliable.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
> _______________________________________________
> Polipo-users mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/polipo-users
>

------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk

_______________________________________________
Polipo-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/polipo-users