Re: js-annoyances filter and referrer

Am 04.04.2013 18:08, schrieb Fabian Keil:
> Sebastian Müller <[email protected]> wrote:
>
>> surfing mindfactory.de, their content is not working (particulary not
>> displayable) using js-annoyances filter. Especially the tabs which are
>> displaying details on the product arent working.
>> The regex is not matching if it has to use ",' or no quotes in context.
>>
>> http://www.mindfactory.de/templates/mindfactory/javascript/tag.min.js
>> line 2 char 128
>>
>> Dunno if this is a general problem or a very specific.
> The js-* filters are known to be unreliable in general.
Yeah of course, I am playing currently around with it a bit, I like them.
>> s|(?:\w+\.)+referrer|none|gisU
>> Is working (for them), while versions with !,",' are not.
>>
>>
>> Can anybody confirm this?
> I haven't tested it, but it seems likely that 'none' is
> valid in more contexts than a string in which case it
> should break less sites.
>
> If there are no objections, I'll change the filter in a couple
> of days.
I tried to look a little deeper, since another part of the site was 
still not working using 'none' (Image preview caroussel).
They are using a jQuery Plugin which is used by many* sites (*google 
search),

http://www.heise.de/extras/socialshareprivacy/
That addon is using document.referrer_track in a few positions, so 
none_track seems to failure there.
After looking in the javascript documentation, for me it seems to be the 
best solution to use for default.filter

s|(?:\w+\.)+referrer|document.URL|gisU

That should prevent failures due to quotes and/or expressions like 
0,false,none a.s.o.
Also should document.URL be syntax-valid.
(http://www.w3schools.com/jsref/prop_doc_url.asp)

Sebastian

------------------------------------------------------------------------------
Minimize network downtime and maximize team effectiveness.
Reduce network management and security costs.Learn how to hire 
the most talented Cisco Certified professionals. Visit the 
Employer Resources Portal
http://www.cisco.com/web/learning/employer_resources/index.html