Re: pipelining setting

Lee <[email protected]> wrote:

> On 6/30/13, Fabian Keil <[email protected]> wrote:
> > Lee <[email protected]> wrote:

> >> >> Fabian - is this bit correct?
> >> >>
> >> >> #  Default value:
> >> >> #
> >> >> #      None
> >> >>
> >> >> sure looks like the default is 0
> >> >
> >> > In the config file "None", "Unset" and "0" currently refer to the
> >> > same numeric default value. I wouldn't be opposed to consistently
> >> > using "0".
> >>
> >> 0 would be better.  None implies neither 0 or 1
> >> Want me to do it?  Changes would be to
> >> current/doc/source/p-config.sgml
> >> - right?
> >
> > p-config.sgml is right and I agree that using a numerical default value
> > would be more appropriate, so feel free to change it.
> 
> I might have gone a bit overboard with the changes.  See
> https://sourceforge.net/tracker/?func=detail&aid=3614613&group_id=11118&atid=311118
> 
> let me know what you'd like changed or how much/little you want
> committed.

I agree with changing the "Default value" from "Unset" to "0",
but would prefer to keep the "Effect if unset:" text.

<emphasis> tags aren't appropriate for filenames and parameters.
We should probably consistently use <filename> and <replaceable>
tags instead (even though p-config.sgml is currently inconsistent).

There seem to be a couple of unrelated formatting and language changes
in the patch. I'm not opposed to them, but in my opinion they belong in
separate commits with fitting commit messages.

I don't quite understand this change:

|@@ -2671,30 +2658,28 @@
| <variablelist>
|  <varlistentry>
|   <term>Specifies:</term>
|   <listitem>
|    <para>
|-    Whether or not pipelined requests should be served.
|+    Whether or not pipelined requests should be handled.

At least to me "served" means sending a response, while "handled"
merely implies doing something with the request which includes
dropping it.

Thus in my opinion Privoxy is always "handling" pipelined requests,
but only "serving" them when configured to do so.

Fabian

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev

_______________________________________________
Ijbswa-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ijbswa-developers

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (FreeBSD)

iQIcBAEBCAAGBQJR0rLLAAoJEGkYIpGLojccCi8P/3N7bRtcv2Ua2pnIF8kj+ogz
dJ5DAa7JS3FFp/5mqXSLe477bSKbK1I6NiL/ZM1T8B2Lint2R2MnbwzcotpvXJQa
/KHMpgp8tfyhPlqrh/iCEvfmeJTt0A7Eox/N5AvZHQWm0TskQNnNrpQXhkXxVdg5
bfUdb24E+Ky14+5Dj4YOaK7dkJY5iyOu4ZfzVGohG2Bs5fx2hQ2QhnuwGFGqRmWb
LX6GfLvBucqLznc9ngpeIWUhKGJ/KeGmq1d62cvo8dsvSoXa0dM42TkP8sGweL7m
9UUmSdyegDXk15H+bgSxCBP8X0FLLOgkJ/yrRmFPMOoq8JCfUukUPsZ/n8RbD/5w
s+hS30HhB3LwtD6Cd9cMHU51bnQ5gDl6P33fvmBhrqvs2zJOEb2hABeHuO+7OVDD
7OFBK4kjXIuQrY30BTL4K3fzM7I6x9UzkYnfllVq2leSBbwKNBUMFCs/pOZ/AtV6
mKJCyCAS1nJYuNLrgv3hkIUTijyAz4m1MB2K6qfbVmwvRXsTJlOZdWUfD0TrNvQn
ghAZrr9RexRn6fyJRyqijihxp0eijmVAI5ThPpnPBtpQ0X0AmJu1KMhpN7jy20YE
E1lFnB5Om4mRfAZjIEyn9xdi3PbuVp8PDqBi/hgKnm6gQj6wyYsyNaJjmVFaZ9rN
ztcspVv/8yU4+gqEJlc2
=pFoW
-----END PGP SIGNATURE-----