Re: Release date for Privoxy 3.0.24
Ian Silvester <[email protected]> Wed, 20 Jan 2016 11:08:36 -0500
| Newsgroups | gmane.comp.web.privoxy.devel |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format. --===============5849242666482780295== Content-Type: multipart/alternative; boundary="------------060509050108050905050306" This is a multi-part message in MIME format. --------------060509050108050905050306 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit I have tested removal of the get_thread_id MACH IFDEF. It is indeed strictly unnecessary since even without it the threads are still uniquely identified. I propose however that it is kept and modified as per the compiler warning, since the raw IDs use four extra bytes which could better be used by the remainder of the log line, plus the comment in the code is strictly true. Let me know if anyone disagrees. Here are log snippets before and after the IFDEF removal: 2016-01-19 23:11:43.935 000003c8 Info: Privoxy version 3.0.24 2016-01-19 23:11:43.936 000003c8 Info: Program name: /usr/local/sbin/privoxy 2016-01-19 23:11:43.944 000003c8 Info: Loading filter file: /usr/local/etc/privoxy/default.filter 2016-01-19 23:11:43.956 000003c8 Info: Loading filter file: /usr/local/etc/privoxy/user.filter 2016-01-19 23:11:43.957 000003c8 Info: Loading actions file: /usr/local/etc/privoxy/match-all.action 2016-01-19 23:11:43.958 000003c8 Info: Loading actions file: /usr/local/etc/privoxy/default.action 2016-01-19 23:11:43.971 000003c8 Info: Loading actions file: /usr/local/etc/privoxy/user.action 2016-01-19 23:11:43.983 000003c8 Info: Loading actions file: /usr/local/etc/privoxy/regression-tests.action 2016-01-19 23:11:43.997 000003c8 Error: block action without reason found. This may become a fatal error in future versions. 2016-01-19 23:11:44.000 000003c8 Info: Listening on port 8118 on IP address 127.0.0.1 2016-01-19 23:11:46.782 00000128 Request: api.simperium.com:443/ 2016-01-19 23:11:47.027 00000368 Request: api.simperium.com:443/ 2016-01-19 23:11:47.792 000001c0 Request: notify3.dropbox.com:443/ 2016-01-19 23:12:05.013 00000018 Request: client-cf.dropbox.com:443/ 2016-01-19 23:12:19.040 00000258 Request: www.google.com:443/ 2016-01-20 09:35:34.135 7fff78fb5000 Info: Privoxy version 3.0.24 2016-01-20 09:35:34.135 7fff78fb5000 Info: Program name: /usr/local/sbin/privoxy 2016-01-20 09:35:34.141 7fff78fb5000 Info: Loading filter file: /usr/local/etc/privoxy/default.filter 2016-01-20 09:35:34.181 7fff78fb5000 Info: Loading filter file: /usr/local/etc/privoxy/user.filter 2016-01-20 09:35:34.182 7fff78fb5000 Info: Loading actions file: /usr/local/etc/privoxy/match-all.action 2016-01-20 09:35:34.183 7fff78fb5000 Info: Loading actions file: /usr/local/etc/privoxy/default.action 2016-01-20 09:35:34.209 7fff78fb5000 Info: Loading actions file: /usr/local/etc/privoxy/user.action 2016-01-20 09:35:34.218 7fff78fb5000 Info: Loading actions file: /usr/local/etc/privoxy/regression-tests.action 2016-01-20 09:35:34.232 7fff78fb5000 Error: block action without reason found. This may become a fatal error in future versions. 2016-01-20 09:35:34.235 7fff78fb5000 Info: Listening on port 8118 on IP address 127.0.0.1 2016-01-20 09:35:35.603 700000081000 Request: api.simperium.com:443/ 2016-01-20 09:35:35.857 700000104000 Request: api.simperium.com:443/ 2016-01-20 09:35:39.626 700000187000 Request: notify3.dropbox.com:443/ 2016-01-20 09:36:16.022 70000020a000 Request: www.google.com:443/ Ian On 2016-01-19 14:34, Ian Silvester wrote: > > > On 2016-01-19 12:30, Fabian Keil wrote: >> Ian Silvester<[email protected]> wrote: >> >>> I've fixed my build environment so an OS X release is back on schedule. >> Great. > I spoke slightly too soon. > > Whilst I have a working binary it seems that the version I have of > Apple's own package building tool no longer runs on my system. Apple's > monolithic approach to dev tool distribution means I cannot upgrade it > without risking the loss of down-level target SDKs. I am therefore > evaluating a free alternative and have high hopes of transitioning to it. > > At this rate I'll be a few days behind the curve, but I don't see a > problem with that. >>> One item of note is that Apple has replaced gcc with LLVM/clang, which >>> throws the following warning on compilation: >>> >>> errlog.c:429:18: warning: absolute value function 'abs' given an >>> argument of type 'long' but has parameter of type 'int' which may >>> cause truncation of value [-Wabsolute-value] >>> this_thread = abs(this_thread % 1000); >>> ^ >>> errlog.c:429:18: note: use function 'labs' instead >>> this_thread = abs(this_thread % 1000); >>> ^~~ >>> labs >>> >>> Clearly the sizes of long and int are platform dependent, but I don't >>> know if the code change it is suggesting is viable. >> Given that the code is in an "#ifdef __MACH__" block > I didn't look into the source file, assuming it was a different level > of strictness from LLVM; clearly I should have done! >> I have >> no strong opinions on how to deal with the warning and if >> it should happen before the release. >> >> While using labs() seems viable, it's not obvious to me that the >> whole line is (still) useful. If it isn't, removing it may be an >> even better idea. >> >> Could you try that and check how the thread ids in the log messages change? > Okay, will do. > > Ian > >> Fabian >> >> >> ------------------------------------------------------------------------------ >> Site24x7 APM Insight: Get Deep Visibility into Application Performance >> APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month >> Monitor end-to-end web transactions and take corrective actions now >> Troubleshoot faster and improve end-user experience. Signup Now! >> http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 >> >> >> _______________________________________________ >> Ijbswa-developers mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/ijbswa-developers > > -- > My PGP public key > <http://diem.serveftp.net:8080/IanSilvesterPGPPublicKey.asc>. > > > ------------------------------------------------------------------------------ > Site24x7 APM Insight: Get Deep Visibility into Application Performance > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > Monitor end-to-end web transactions and take corrective actions now > Troubleshoot faster and improve end-user experience. Signup Now! > http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 > > > _______________________________________________ > Ijbswa-developers mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ijbswa-developers -- My PGP public key <http://diem.serveftp.net:8080/IanSilvesterPGPPublicKey.asc>. --------------060509050108050905050306 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: 8bit <html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> I have tested removal of the get_thread_id MACH IFDEF. It is indeed strictly unnecessary since even without it the threads are still uniquely identified. I propose however that it is kept and modified as per the compiler warning, since the raw IDs use four extra bytes which could better be used by the remainder of the log line, plus the comment in the code is strictly true.<br> <br> Let me know if anyone disagrees.<br> <br> Here are log snippets before and after the IFDEF removal:<br> <br> <br> 2016-01-19 23:11:43.935 000003c8 Info: Privoxy version 3.0.24<br> 2016-01-19 23:11:43.936 000003c8 Info: Program name: /usr/local/sbin/privoxy<br> 2016-01-19 23:11:43.944 000003c8 Info: Loading filter file: /usr/local/etc/privoxy/default.filter<br> 2016-01-19 23:11:43.956 000003c8 Info: Loading filter file: /usr/local/etc/privoxy/user.filter<br> 2016-01-19 23:11:43.957 000003c8 Info: Loading actions file: /usr/local/etc/privoxy/match-all.action<br> 2016-01-19 23:11:43.958 000003c8 Info: Loading actions file: /usr/local/etc/privoxy/default.action<br> 2016-01-19 23:11:43.971 000003c8 Info: Loading actions file: /usr/local/etc/privoxy/user.action<br> 2016-01-19 23:11:43.983 000003c8 Info: Loading actions file: /usr/local/etc/privoxy/regression-tests.action<br> 2016-01-19 23:11:43.997 000003c8 Error: block action without reason found. This may become a fatal error in future versions.<br> 2016-01-19 23:11:44.000 000003c8 Info: Listening on port 8118 on IP address 127.0.0.1<br> 2016-01-19 23:11:46.782 00000128 Request: api.simperium.com:443/<br> 2016-01-19 23:11:47.027 00000368 Request: api.simperium.com:443/<br> 2016-01-19 23:11:47.792 000001c0 Request: notify3.dropbox.com:443/<br> 2016-01-19 23:12:05.013 00000018 Request: client-cf.dropbox.com:443/<br> 2016-01-19 23:12:19.040 00000258 Request: <a class="moz-txt-link-abbreviated" href="http://www.google.com:443/">www.google.com:443/</a><br> <br> <br> <br> 2016-01-20 09:35:34.135 7fff78fb5000 Info: Privoxy version 3.0.24<br> 2016-01-20 09:35:34.135 7fff78fb5000 Info: Program name: /usr/local/sbin/privoxy<br> 2016-01-20 09:35:34.141 7fff78fb5000 Info: Loading filter file: /usr/local/etc/privoxy/default.filter<br> 2016-01-20 09:35:34.181 7fff78fb5000 Info: Loading filter file: /usr/local/etc/privoxy/user.filter<br> 2016-01-20 09:35:34.182 7fff78fb5000 Info: Loading actions file: /usr/local/etc/privoxy/match-all.action<br> 2016-01-20 09:35:34.183 7fff78fb5000 Info: Loading actions file: /usr/local/etc/privoxy/default.action<br> 2016-01-20 09:35:34.209 7fff78fb5000 Info: Loading actions file: /usr/local/etc/privoxy/user.action<br> 2016-01-20 09:35:34.218 7fff78fb5000 Info: Loading actions file: /usr/local/etc/privoxy/regression-tests.action<br> 2016-01-20 09:35:34.232 7fff78fb5000 Error: block action without reason found. This may become a fatal error in future versions.<br> 2016-01-20 09:35:34.235 7fff78fb5000 Info: Listening on port 8118 on IP address 127.0.0.1<br> 2016-01-20 09:35:35.603 700000081000 Request: api.simperium.com:443/<br> 2016-01-20 09:35:35.857 700000104000 Request: api.simperium.com:443/<br> 2016-01-20 09:35:39.626 700000187000 Request: notify3.dropbox.com:443/<br> 2016-01-20 09:36:16.022 70000020a000 Request: <a class="moz-txt-link-abbreviated" href="http://www.google.com:443/">www.google.com:443/</a><br> <br> <br> Ian<br> <br> <br> <div class="moz-cite-prefix">On 2016-01-19 14:34, Ian Silvester wrote:<br> </div> <blockquote cite="mid:[email protected]" type="cite"> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> <br> <br> <div class="moz-cite-prefix">On 2016-01-19 12:30, Fabian Keil wrote:<br> </div> <blockquote cite="mid:[email protected]" type="cite"> <pre wrap="">Ian Silvester <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:[email protected]"><[email protected]></a> wrote: </pre> <blockquote type="cite"> <pre wrap="">I've fixed my build environment so an OS X release is back on schedule. </pre> </blockquote> <pre wrap="">Great.</pre> </blockquote> I spoke slightly too soon.<br> <br> Whilst I have a working binary it seems that the version I have of Apple's own package building tool no longer runs on my system. Apple's monolithic approach to dev tool distribution means I cannot upgrade it without risking the loss of down-level target SDKs. I am therefore evaluating a free alternative and have high hopes of transitioning to it.<br> <br> At this rate I'll be a few days behind the curve, but I don't see a problem with that.<br> <blockquote cite="mid:[email protected]" type="cite"> <blockquote type="cite"> <pre wrap="">One item of note is that Apple has replaced gcc with LLVM/clang, which throws the following warning on compilation: errlog.c:429:18: warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value] this_thread = abs(this_thread % 1000); ^ errlog.c:429:18: note: use function 'labs' instead this_thread = abs(this_thread % 1000); ^~~ labs Clearly the sizes of long and int are platform dependent, but I don't know if the code change it is suggesting is viable. </pre> </blockquote> <pre wrap="">Given that the code is in an "#ifdef __MACH__" block</pre> </blockquote> I didn't look into the source file, assuming it was a different level of strictness from LLVM; clearly I should have done! <br> <blockquote cite="mid:[email protected]" type="cite"> <pre wrap=""> I have no strong opinions on how to deal with the warning and if it should happen before the release. While using labs() seems viable, it's not obvious to me that the whole line is (still) useful. If it isn't, removing it may be an even better idea. Could you try that and check how the thread ids in the log messages change?</pre> </blockquote> Okay, will do.<br> <br> Ian<br> <br> <blockquote cite="mid:[email protected]" type="cite"> <pre wrap=""> Fabian </pre> <br> <fieldset class="mimeAttachmentHeader"></fieldset> <br> <pre wrap="">------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140">http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140</a></pre> <br> <fieldset class="mimeAttachmentHeader"></fieldset> <br> <pre wrap="">_______________________________________________ Ijbswa-developers mailing list <a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:[email protected]">[email protected]</a> <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://lists.sourceforge.net/lists/listinfo/ijbswa-developers">https://lists.sourceforge.net/lists/listinfo/ijbswa-developers</a> </pre> </blockquote> <br> <div class="moz-signature">-- <br> <a moz-do-not-send="true" href="http://diem.serveftp.net:8080/IanSilvesterPGPPublicKey.asc">My PGP public key</a>.</div> <br> <fieldset class="mimeAttachmentHeader"></fieldset> <br> <pre wrap="">------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! <a class="moz-txt-link-freetext" href="http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140">http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140</a></pre> <br> <fieldset class="mimeAttachmentHeader"></fieldset> <br> <pre wrap="">_______________________________________________ Ijbswa-developers mailing list <a class="moz-txt-link-abbreviated" href="mailto:[email protected]">[email protected]</a> <a class="moz-txt-link-freetext" href="https://lists.sourceforge.net/lists/listinfo/ijbswa-developers">https://lists.sourceforge.net/lists/listinfo/ijbswa-developers</a> </pre> </blockquote> <br> <div class="moz-signature">-- <br> <a href="http://diem.serveftp.net:8080/IanSilvesterPGPPublicKey.asc">My PGP public key</a>.</div> </body> </html> --------------060509050108050905050306-- --===============5849242666482780295== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 --===============5849242666482780295== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Ijbswa-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ijbswa-developers --===============5849242666482780295==--