privoxy-3.0.31-stable/jcc.c:3944:25: style: Suspicious condition

David Binderman <[email protected]> Tue, 2 Feb 2021 10:53:46 +0000

Newsgroups	gmane.comp.web.privoxy.user
Message-ID	<DB6P189MB0568F57F54DE867B75ED8B739CB59@DB6P189MB0568.EURP189.PROD.OUTLOOK.COM>

Hello there,

Some static analysis has produced this message:

privoxy-3.0.31-stable/jcc.c:3944:25: style: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]

Source code is

                     || (len = ssl_flush_socket(&(csp->ssl_client_attr),
                            csp->iob) < 0))
                  {

Maybe better code

                     || ((len = ssl_flush_socket(&(csp->ssl_client_attr),
                            csp->iob)) < 0))
                  {

Regards

David Binderman