Re: privoxy-3.0.31-stable/jcc.c:3944:25: style: Suspicious condition

Fabian Keil <[email protected]> Wed, 3 Feb 2021 12:04:25 +0100

Newsgroups	gmane.comp.web.privoxy.user
Message-ID	<[email protected]>

David Binderman <[email protected]> wrote on 2021-02-02:

> Some static analysis has produced this message:
> 
> privoxy-3.0.31-stable/jcc.c:3944:25: style: Suspicious condition
> (assignment + comparison); Clarify expression with parentheses.
> [clarifyCondition]
[...]
> Maybe better code
> 
>                      || ((len = ssl_flush_socket(&(csp->ssl_client_attr),
>                             csp->iob)) < 0))

Thanks for the report. I added the parentheses:
https://www.privoxy.org/gitweb/?p=privoxy.git;a=commitdiff;h=1735db35cf6e78e892535418accc59f23c335881

Fabian

_______________________________________________
Privoxy-users mailing list
[email protected]
https://lists.privoxy.org/mailman/listinfo/privoxy-users

signature.asc (application/pgp-signature, 833 B)