Re: First round of comments merging done

On Thu, 9 Dec 2004, Bill Mill wrote:
>
> what couple of other things? the pyxml is the only requirement that I 
> really don't like, and I agree with you about the template stomping. 
> However, I couldn't convince myself to rewrite a plugin that was 
> functional for a whole bunch of people (and this is coming from a guy 
> who rewrote both the pathinfo and filelist handlers just so he could 
> understand them better).

Well, I probably wouldn't "re-write" it.  I'd just "fork" the plugin and 
maintain my own version of it that has the bits I need and doesn't have 
the bits I don't need.  I'd then offer it as an alternative comments 
plugin on the registry so other people could take advantage of it if it 
happened to meet their needs as well.

This isn't that different from what we have now.  I have my own version of 
comments--though Ted says he's merged a bunch of the differences into the 
main version.

It's just a thought at this point.  I don't mean to threaten anyone. 
Though the template-stomping issue is definitely a show-stopper for me. 
I can't use the comments plugin with that and it adversely affects a bunch 
of the other plugins I've written (plugin-info, booklist, pystaticfile, 
...) which all rely on the ability to change the template from "story" to 
something else.


> If I had my druthers, we'd pickle the comments instead of putting them 
> in xml. When would they ever need to be read by anything but Python? I 
> don't see much advantage there.

If I recall, it had something to do with it being easy to send them 
through an RSS feed.  Or something like that.  I forget why Ted chose xml 
specifically.

I'd probably switch it to use pickled dicts or just text files.

/will


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/