Re: First round of comments merging done

will guaraldi <[email protected]>
Newsgroups gmane.comp.web.pyblosxom.devel
Message-ID <[email protected]>
On Thu, 9 Dec 2004, Ted Leung wrote:
> 
> Whoa.
>
> Okay, let me clarify.
>
> I didn't merge template stomping because it broke my blog (i started 
> getting 2 copies of the actual post).  I didn't have enough time last 
> night to figure out why.  So I'll look at it tonight and figure out 
> where the problem is.
>
> If people want to refactor the plugin that's fine by me.  That's the 
> point of all this being open source.  I will point out, that too much 
> choice can be confusing for people, which is why I wanted to try to 
> consolidate all the changes to begin with.  It's been a disappointment 
> to me that there are so many mods to pyblosxom and the plugins out in 
> the wild, but we've seen very few of those changes come back and be 
> incorporated in the core/core plugins.
>
> As far as XML goes, the reason I did it was to facilitate building a 
> comments feed or something like that.  I do have a comments feed and 
> quite a decent number of people subscribe to it.  I would be amenable to 
> getting rid of the dependency on pyxml -- This is mostly vestigal.

Ok.  That's cool with me, Ted.  I totally withdraw all my sinister plans 
to fork the comments module.  ;)

I don't care enough about the pyxml dependency to fork or anything.  I 
think it's fine.  Just figured while I was busy planning my future forking 
plans I might as well change that as well to catch another group of people 
who might have been disenfranchised.

(shrug)

In regards to your comment about people not merging changes with the 
original, there's no process for that.  There's very little community 
communication--there should be a lot more given the amount of activity 
there is in the pyblosxom periphery.

I would suggest you add a couple of lines tot he comments plugin along the 
lines of:

%<------
If you make any changes to this plugin, please a diff of the changes to 
<some email address> so that we can factor those changes in.  Thanks!
%<------

I'm thinking people need explicit directions otherwise they just do 
whatever it is they do.

/will


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.