Re: First round of comments merging done

Whoa.

Okay, let me clarify.

I didn't merge template stomping because it broke my blog (i started 
getting 2 copies of the actual post).  I didn't have enough time last 
night to figure out why.  So I'll look at it tonight and figure out 
where the problem is.

If people want to refactor the plugin that's fine by me.  That's the 
point of all this being open source.  I will point out, that too much 
choice can be confusing for people, which is why I wanted to try to 
consolidate all the changes to begin with.  It's been a disappointment 
to me that there are so many mods to pyblosxom and the plugins out in 
the wild, but we've seen very few of those changes come back and be 
incorporated in the core/core plugins.

As far as XML goes, the reason I did it was to facilitate building a 
comments feed or something like that.  I do have a comments feed and 
quite a decent number of people subscribe to it.   I would be amenable 
to getting rid of the dependency on pyxml -- This is mostly vestigal.

On Dec 9, 2004, at 10:50 AM, will guaraldi wrote:

> On Thu, 9 Dec 2004, Steven Armstrong wrote:
>>
>> After thinking a bit about the 'template stomping issue' I think Will 
>> is right. When I look at my comment-story.html, its pretty much the 
>> same as story.html anyway. I'll rewrite my html and css to work 'the 
>> Will way'. Makes sense to me not to have redundant html snippets 
>> arround.
>>
>> I think before forking the plugin it would be a good idea to talk 
>> about it and make a feature list or so.
>
> Hmmm...  I think this is getting more attention than I was expecting. 
> Ted wrote the comments plugin and as far as I'm concerned, it's just 
> fine except for the template-stomping issue.  My issue with the 
> template-stomping stems from the fact that it screws up a bunch of my 
> plugins and I don't have another way to fix the issues involved.  
> Beyond that, I neither like nor dislike the template-stomping.
>
> I only meant to point out that I can't use a comments plugin that 
> stomps on the template specified in the entry because it screws up my 
> plugins. Given that, I'll probably maintain my own comments plugin 
> (something I've been doing for over 6 months anyhow).  Given that, I 
> might as well offer my version as an alternative to the community by 
> registering it in the plugin registry.  Given that, I might as well 
> make some other changes because at that point I'd be maintaining my 
> own version anyhow.
>
> So...  that's what I mean by "forking" the comments plugin.
>
> I definitely don't want to refactor the code.  I don't see any good 
> reason to do that and I don't care enough to argue or discuss it.  If 
> other people see a good reason for it and want to refactor it, that's 
> cool--make your own comments plugin.
>
> I also definitely don't want to turn it into a committee-based 
> project. I'm really only looking to fix my specific needs and figured 
> that while I'm doing that I might as well offer it to the community.
>
> So, that's where I'm coming from.  If Ted wants to remove the 
> template-stomping, then I have no issues and I will definitely take 
> the path of least resistance because time is really really really 
> precious right now and there are other things to work on.  If Ted 
> decides there's a good reason for the template-stomping and thus keeps 
> it (which is totally fine with me), then I'll maintain my own version 
> and blah blah blah.
>
> I hope that clears up any misconceptions.
>
> /will
>
>
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real 
> users.
> Discover which products truly live up to the hype. Start reading now. 
> http://productguide.itmanagersjournal.com/
> _______________________________________________
> Pyblosxom-devel mailing list
> Pyblosxom-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/pyblosxom-devel
>
----
Ted Leung                          Blog: <http://www.sauria.com/blog>
PGP Fingerprint: 1003 7870 251F FA71 A59A  CEE3 BEBA 2B87 F5FC 4B42



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/