Re: pyblosxom 3000

Steven--sorry it's taken me so long to get to this.  I applied the patch 
and had some minor issues (which are likely due to my making some minor 
changes to pyblosxom.py after you did the diff)--but otherwise it runs 
fine on my site (haven't tried xmlrpc yet, though).  I skimmed the code 
and don't have any first-blush objections.

There's a section of code in the verify installation that's commented out 
that tests for the existence of the datadir.  Did you comment that out on 
purpose?  Is there something wrong with it?

Anyone else look at the patch?  Any objections to my checking it in?

/will


On Thu, 20 Jan 2005, Steven Armstrong wrote:
> 
> Ok, here goes.
>
> I've changed quite a few things. It's possible that this breaks stuff that 
> (a) I don't have installed and therefor don't know about, (b) haven't 
> tested/thought of.
>
> Some changes might look strange/overkill to someone looking at it solely from 
> the CGI point of view. But when looking at it from a twisted, mod_python, 
> whatever point of view I think it's actually pretty cool :-)
>
> The patch changes the following files:
> /pyblosxom/web/pyblosxom.cgi
> /pyblosxom/Pyblosxom/pyblosxom.py
> /pyblosxom/Pyblosxom/tools.py
> /pyblosxom/Pyblosxom/renderers/base.py
>
> What I've tested sucessfully:
> - normal CGI usage
> - static rendering, static incremental rendering
> - testing installation
>
> plugins I had loaded while testing this:
> "pystaticfile", "breadcrumbs", "pycalendar", "pycategories",
> "comments", "rss2renderer", "w3cdate", "rememberdates",
> "lupy_search", "abstract", "session", "nospam",
> "xmlrpc", "xmlrpc_blogger", "xmlrpc_metaweblog",
> "xmlrpc_editor", "flow", "rewrite", "cat"
>
> xmlrpc needed to be patched to not read from sys.stdin.
> rememberdates had to patched to work with static rendering.
>
> What say you?
>
> cheers
> Steven


-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl