Re: pyblosxom 3000

will guaraldi wrote:
> Steven--sorry it's taken me so long to get to this.  I applied the patch 
> and had some minor issues (which are likely due to my making some minor 
> changes to pyblosxom.py after you did the diff)--but otherwise it runs 
> fine on my site (haven't tried xmlrpc yet, though).  I skimmed the code 
> and don't have any first-blush objections.
> 
> There's a section of code in the verify installation that's commented out 
> that tests for the existence of the datadir.  Did you comment that out on 
> purpose?  Is there something wrong with it?
> 

There's a line saying "# FIXME - we should check permissions here?" so I
thought I'll try to code that. While doing so I figured that the only
thing I can check easily is if the user himself has read/write
permissions on the datadir.

But the really interesting question is if the webserver has read access.
This is far more difficult to implement as the webserver user will be
different from os to os. (e.g. apache, www-data, whatever)

That's why I commented it out again.

If you think the check still makes sense, you should change the suffix
of the testfile from "_test_installation_read_write_access.txt" to e.g.
"test_installation_read_write_access.xyz" so it doesn't show up as a
blog entry. Just incase something goes wrong while removing it again
after the test.

> Anyone else look at the patch?  Any objections to my checking it in?
> 
> /will
> 


-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl