Re: [PATCH] Trackback+akismetcomments

On Sat, 29 Dec 2007, Michael Guntsche wrote:

> Please take a look at the following patch. It adds the pending changes and
> also fixes a problem with non-ASCII characters in comments. I removed all
> json related stuff for now.

thanks! overall, this looks good. a few comments:

looking at the comments.js change, i'm not familiar with encodeURIComponent().
...ah, ok, it's evidently a built-in javascript function, intended to replace 
escape(). i wonder how well it's supported across current browsers and browser 
versions...?

looking at the comments.py change, pyblosxom defaults the blog_encoding config 
var to iso-8859-1, not utf-8. given that, the ajax renderer should probably 
default to iso-8859-1 too. also, minor style nitpick, line 737: has_key is 
deprecated, style-wise, in favor of the 'in' operator.

finally, if you're off this week, mind adding tests for your changes? there's 
an existing test file for akismetcomments, but you'd need to create one for 
trackback. copy and paste should work fine. :P thanks in advance!

oh, and btw, you're a committer, so when the patch and tests are ready, you're 
welcome to check them in yourself.

-Ryan

--
http://snarfed.org/

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/