Re: [PATCH] Trackback+akismetcomments

On Dec 29, 2007, at 20:33, Ryan Barrett wrote:

>
> looking at the comments.js change, i'm not familiar with  
> encodeURIComponent().
> ...ah, ok, it's evidently a built-in javascript function, intended  
> to replace escape(). i wonder how well it's supported across  
> current browsers and browser versions...?
>
Well it fully supports non ASCII characters which escape does not do  
all to well. As for supported in browsers all the current browsers  
support it, has been tested with (IE 6,7, Safari, firefox and I think  
also an opera version).

> looking at the comments.py change, pyblosxom defaults the  
> blog_encoding config var to iso-8859-1, not utf-8. given that, the  
> ajax renderer should probably default to iso-8859-1 too. also,  
> minor style nitpick, line 737: has_key is deprecated, style-wise,  
> in favor of the 'in' operator.

If utf-8 isn't used you almost always run into problems with  
international comments (Euro sign, japanese Names). You do not have  
that with UTF-8. AS you can see utf-8 is just used to get the comment  
to the server, later on it gets encoded to the blog encoding anyway.



> finally, if you're off this week, mind adding tests for your  
> changes? there's an existing test file for akismetcomments, but  
> you'd need to create one for trackback. copy and paste should work  
> fine. :P thanks in advance!
>
Slight misunderstanding. I have a one week break from work, so I can  
spend MORE time on pyblosxom next week. I'll read up on the tests and  
try to wip something up.


> oh, and btw, you're a committer, so when the patch and tests are  
> ready, you're welcome to check them in yourself.
>
I know, I just wanted to send them out for review first.

Since we are talking plugins now. Do we have a defined way to deal  
with plugins and the different pyblosxom versions (1.4, 2.0-trunk).  
There are already changes in current trunk that break some plugins  
and more will follow. Should we have one plugin that works with both  
versions or two separate plugins?
Personally I think that one plugin is good as long as the differences  
are not too big.


Kind regards,
Michael

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

_______________________________________________
Pyblosxom-devel mailing list
Pyblosxom-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/pyblosxom-devel