Re: comments plugin fails when post is in datadir root

I haven't gotten to looking at this problem (or other comments plugin 
problems) yet.

I think I'll have to track down what absolute_path is supposed to be and 
what makes it different from other *path vars.

I'll try to get to it soon.


On 01/05/2010 08:04 AM, Sebastian Spaeth wrote:
> I just reported
> https://sourceforge.net/tracker/?func=detail&aid=2926212&group_id=67445&atid=517918
> and the same issue was mentioned here:
> http://thread.gmane.org/gmane.comp.web.pyblosxom.devel/2166
>
> comments.py contains a check in cb_story() that abort comment reading
> when it fails:
>
> if entry['absolute_path'] and not entry.has_key("nocomments"):
>
> the thing is "absolute_path" is "" when a post is in the datadir root
> (ie in no category) and comments won't be read. This means the number of
> comments isn't displayed in the list view and there is no "post comment"
> link in the story-view.
>
> IMHO the absolute_path test is bogus and should simply be removed. I
> have done so locally and things work as expected now.
>
> -if entry['absolute_path'] and not entry.has_key("nocomments"):
> +if not entry.has_key("nocomments"):
>
> If more experienced devs agree, it would be good to make that change.
>
> spaetz
>
> ------------------------------------------------------------------------------
> This SF.Net email is sponsored by the Verizon Developer Community
> Take advantage of Verizon's best-in-class app development support
> A streamlined, 14 day to market process makes app distribution fast and easy
> Join now and get one step closer to millions of Verizon customers
> http://p.sf.net/sfu/verizon-dev2dev
> _______________________________________________
> Pyblosxom-devel mailing list
> Pyblosxom-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/pyblosxom-devel
>

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev