Re: [webmin-devel] Webmin
"Jamie Cameron" <[email protected]> Fri, 27 Jul 2012 12:24:20 -0700 (PDT)
| Newsgroups | gmane.comp.web.webmin.devel |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format. --bound1343417060 Content-Type: multipart/alternative; boundary="altsbound1343417060" Content-Transfer-Encoding: 7bit --altsbound1343417060 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Hi David, Thanks for those patches - however, regarding the one for the init module, does using the service command not work at all? I recall that I chose that over initctl as on some older Debian versions the initctl command wasn't available. Perhaps alternately initctl should be used if it exists, otherwise fall back to the service command? On 27/Jul/2012 08:25 David Lam <[email protected]> wrote .. Hi Jamie, I think these two patches are correct. init-lib.patch - Upstart services should call "initctl" instead of "service". webmin-sshd.patch - Fixed typo and changed "rsa" to "dsa". Added 'AUTHPRIV' to list of syslog facility codes. Thanks! (See attached file: webmin-sshd.patch)(See attached file: init-lib.patch) Inactive hide details for Jamie Cameron ---07/26/2012 04:20:53 PM---You can just email them to me directly. Or submit them via Jamie Cameron ---07/26/2012 04:20:53 PM---You can just email them to me directly. Or submit them via github.com , in the webmin project. Davi From: Jamie Cameron <[email protected]> To: Webmin development list <[email protected]>, Date: 07/26/2012 04:20 PM Subject: Re: [webmin-devel] Webmin ___________________________________________________________________ You can just email them to me directly. Or submit them via github.com , in the webmin project. David Lam <[email protected]> wrote: Hi, First-time Sourceforge user here. I wanted to send some simple patches for Webmin, but wasn't sure what the best way was. Should I post them on the Patches section, or should I send an email out on the mailing list first? Thanks, David Lam----------------------------------------------------------------------- ------- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. [1]http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/- Forwarded by the Webmin development list at [email protected] To remove yourself from this list, go to [2]http://lists.sourceforge.net/lists/listinfo/webadmin-devel --altsbound1343417060 Content-Type: text/html; charset=US-ASCII Content-Transfer-Encoding: 7bit <p>Hi David,<br /><br />Thanks for those patches - however, regarding the one for the init module, does using the service command not work at all? I recall that I chose that over initctl as on some older Debian versions the initctl command wasn't available.<br /><br />Perhaps alternately initctl should be used if it exists, otherwise fall back to the service command? </p> <p>On 27/Jul/2012 08:25 David Lam <[email protected]> wrote .. </p> <blockquote type="cite"> <p><font size="2" face="sans-serif">Hi Jamie,</font><br /> <br /> <font size="2" face="sans-serif">I think these two patches are correct.</font><br /> <br /> <font size="2" face="sans-serif">init-lib.patch - Upstart services should call "initctl" instead of "service". </font><br /> <br /> <font size="2" face="sans-serif">webmin-sshd.patch - Fixed typo and changed "rsa" to "dsa". Added 'AUTHPRIV' to list of syslog facility codes.</font><br /> <br /> <font size="2" face="sans-serif">Thanks!</font><br /> <br /> <em>(See attached file: webmin-sshd.patch)</em><em>(See attached file: init-lib.patch)</em><br /> <br /> <img width="16" height="16" src="cid:134341706095591" border="0" alt="Inactive hide details for Jamie Cameron ---07/26/2012 04:20:53 PM-- -You can just email them to me directly. Or submit them via " /><font size="2" color="#424282" face="sans-serif">Jamie Cameron ---07/26/2012 04:20:53 PM---You can just email them to me direc tly. Or submit them via github.com , in the webmin project. Davi</font><br /> <br /> <font size="1" color="#5F5F5F" face="sans-serif">From: </font><font size="1" face="sans-serif">Jamie Cameron <[email protected]></font><br /> <font size="1" color="#5F5F5F" face="sans-serif">To: </font><font size="1" face="sans-serif">Webmin development list <[email protected]>, </font><br /> <font size="1" color="#5F5F5F" face="sans-serif">Date: </font><font size="1" face="sans-serif">07/26/2012 04:20 PM</font><br /> <font size="1" color="#5F5F5F" face="sans-serif">Subject: </font><font size="1" face="sans-serif">Re: [webmin-devel] Webmin</font><br /> </p><hr width="100%" size="2" align="left" noshade="noshade" style="color: #8091a5; " /><br /> <br /> <br /> <font s ize="3" face="serif">You can just email them to me directly. Or submit them via github.com , in the webmin project. <br /> <br /> David Lam <[email protected]> wrote:<br /> </font> <p><font size="2" face="sans-serif">Hi,</font><font size="3" face="serif"><br /> </font><font size="2" face="sans-serif"><br /> First-time Sourceforge user here. I wanted to send some simple patches for Webmin, but wasn't sure what the best way was. Should I post them on the Patches section, or should I send an email out on the mailing list first? </font><font size="3" face="serif"><br /> </font><font size="2" face="sans-serif"><br /> Thanks,<br /> David Lam</font><tt><font size="2">------------------------------------------------------------------------------<br /> Live Security Virtual Conference<br /> Exclusive live event will cover all the ways today's security and <br /> threat landscape has changed and how IT managers can respond. Discussions <br /> will include endpoint security, mobile security and the latest in malware <br /> threats. </font></tt><tt><font size="2"><a href="http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/">http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/</a></font></tt><tt><font size="2">-<br /> Forwarded by the Webmin development list at [email protected]<br /> To remove yourself from this list, go to<br /> </font></tt><tt><font size="2"><a href="http://lists.sourceforge.net/lists/listinfo/webadmin-devel">http://lists.sourceforge.net/lists/listinfo/webadmin-devel</a></font></tt><tt><font size="2"><br /> </font></tt> </p> <p> </p> </blockquote><br /> --altsbound1343417060-- --bound1343417060 Content-type: application/octet-stream; name="webmin-sshd.patch" Content-Disposition: attachment; filename="webmin-sshd.patch" Content-ID: <[email protected]> Content-transfer-encoding: base64 ZGlmZiAtLWdpdCBzc2hkL2VkaXRfdXNlcnMuY2dpIHNzaGQvZWRpdF91c2Vycy5jZ2kKaW5kZXgg YTcyZjFmZi4uOGFjYjBiMCAxMDA3NTUKLS0tIHNzaGQvZWRpdF91c2Vycy5jZ2kKKysrIHNzaGQv ZWRpdF91c2Vycy5jZ2kKQEAgLTg0LDcgKzg0LDcgQEAgaWYgKCR2ZXJzaW9ueyd0eXBlJ30gbmUg J3NzaCcgfHwgJHZlcnNpb257J251bWJlcid9IDwgMykgewogCiAjIFNTSCAyIERTQSBhdXRoZW50 aWNhdGlvbgogaWYgKCR2ZXJzaW9ueyd0eXBlJ30gZXEgJ29wZW5zc2gnICYmICR2ZXJzaW9ueydu dW1iZXInfSA+PSAzKSB7Ci0JJHJzYSA9ICZmaW5kX3ZhbHVlKCJQdWJrZXlBdXRoZW50aWNhdGlv biIsICRjb25mKTsKKwkkZHNhID0gJmZpbmRfdmFsdWUoIlB1YmtleUF1dGhlbnRpY2F0aW9uIiwg JGNvbmYpOwogCXByaW50ICZ1aV90YWJsZV9yb3coJHRleHR7J3VzZXJzX2RzYSd9LAogCQkmdWlf eWVzbm9fcmFkaW8oJ2RzYScsIGxjKCRkc2EpIG5lICdubycpKTsKIAl9CmRpZmYgLS1naXQgc3No ZC9zc2hkLWxpYi5wbCBzc2hkL3NzaGQtbGliLnBsCmluZGV4IGZjYmQ1MGYuLmJiOTEwYjEgMTAw NzU1Ci0tLSBzc2hkL3NzaGQtbGliLnBsCisrKyBzc2hkL3NzaGQtbGliLnBsCkBAIC0zNTYsNyAr MzU2LDcgQEAgaWYgKCZmb3JlaWduX2NoZWNrKCJzeXNsb2ciKSkgewogCUBmYWNpbHMgPSBtYXAg eyB1YygkXykgfSBzcGxpdCgvXHMrLywgJHNjb25maWd7J2ZhY2lsaXRpZXMnfSk7CiAJfQogaWYg KCFAZmFjaWxzKSB7Ci0JQGZhY2lscyA9ICggJ0RBRU1PTicsICdVU0VSJywgJ0FVVEgnLCAnTE9D QUwwJywgJ0xPQ0FMMScsICdMT0NBTDInLAorCUBmYWNpbHMgPSAoICdEQUVNT04nLCAnVVNFUics ICdBVVRIJywgJ0FVVEhQUklWJywgJ0xPQ0FMMCcsICdMT0NBTDEnLCAnTE9DQUwyJywKIAkJICAg ICdMT0NBTDMnLCAnTE9DQUw0JywgJ0xPQ0FMNScsICdMT0NBTDYnLCAnTE9DQUw3JyApOwogCX0K IHJldHVybiBAZmFjaWxzOwo= --bound1343417060 Content-type: application/octet-stream; name="init-lib.patch" Content-Disposition: attachment; filename="init-lib.patch" Content-ID: <[email protected]> Content-transfer-encoding: base64 ZGlmZiAtLWdpdCBpbml0L2luaXQtbGliLnBsIGluaXQvaW5pdC1saWIucGwKaW5kZXggODkzMDFk NS4uMzdlYjhkYyAxMDA3NTUKLS0tIGluaXQvaW5pdC1saWIucGwKKysrIGluaXQvaW5pdC1saWIu cGwKQEAgLTE2OTUsNyArMTY5NSw3IEBAIHN1YiBzdGFydF91cHN0YXJ0X3NlcnZpY2UKIHsKIG15 ICgkbmFtZSkgPSBAXzsKIG15ICRvdXQgPSAmYmFja3F1b3RlX2xvZ2dlZCgKLQkic2VydmljZSAi LnF1b3RlbWV0YSgkbmFtZSkuIiBzdGFydCAyPiYxIDwvZGV2L251bGwiKTsKKyAgICAiaW5pdGN0 bCBzdGFydCAiLnF1b3RlbWV0YSgkbmFtZSkuIiAyPiYxIDwvZGV2L251bGwiKTsKIHJldHVybiAo ISQ/LCAkb3V0KTsKIH0KIApAQCAtMTcwOCw3ICsxNzA4LDcgQEAgc3ViIHN0b3BfdXBzdGFydF9z ZXJ2aWNlCiB7CiBteSAoJG5hbWUpID0gQF87CiBteSAkb3V0ID0gJmJhY2txdW90ZV9sb2dnZWQo Ci0JInNlcnZpY2UgIi5xdW90ZW1ldGEoJG5hbWUpLiIgc3RvcCAyPiYxIDwvZGV2L251bGwiKTsK KyAgICAiaW5pdGN0bCBzdG9wICIucXVvdGVtZXRhKCRuYW1lKS4iIDI+JjEgPC9kZXYvbnVsbCIp OwogcmV0dXJuICghJD8sICRvdXQpOwogfQogCkBAIC0xNzIxLDcgKzE3MjEsNyBAQCBzdWIgcmVz dGFydF91cHN0YXJ0X3NlcnZpY2UKIHsKIG15ICgkbmFtZSkgPSBAXzsKIG15ICRvdXQgPSAmYmFj a3F1b3RlX2xvZ2dlZCgKLQkic2VydmljZSAiLnF1b3RlbWV0YSgkbmFtZSkuIiByZXN0YXJ0IDI+ JjEgPC9kZXYvbnVsbCIpOworICAgICJpbml0Y3RsIHJlc3RhcnQgIi5xdW90ZW1ldGEoJG5hbWUp LiIgMj4mMSA8L2Rldi9udWxsIik7CiByZXR1cm4gKCEkPywgJG91dCk7CiB9CiAK --bound1343417060 Content-type: image/gif; name="graycol.gif" Content-Disposition: inline; filename="graycol.gif" Content-transfer-encoding: base64 Content-Id: <134341706095591> R0lGODlhEAAQAKECAMzMzAAAAP///wAAACH5BAEAAAIALAAAAAAQABAAAAIXlI+py+0PopwxUbpu ZRfKZ2zgSJbmSRYAIf4fT3B0aW1pemVkIGJ5IFVsZWFkIFNtYXJ0U2F2ZXIhAAA7 --bound1343417060 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ --bound1343417060 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline - Forwarded by the Webmin development list at [email protected] To remove yourself from this list, go to http://lists.sourceforge.net/lists/listinfo/webadmin-devel --bound1343417060--