Re: [webmin-devel] Webmin

David Lam <[email protected]> Mon, 30 Jul 2012 09:49:03 -0500
Newsgroups gmane.comp.web.webmin.devel
Message-ID <OFA633DDE7.224F57BD-ON87257A4B.004F6B8B-86257A4B.005165B5@us.ibm.com>
--===============1334163486832334081==
Content-type: multipart/related; 
	Boundary="0__=08BBF0D8DFDCED1B8f9e8a93df938690918c08BBF0D8DFDCED1B"

--0__=08BBF0D8DFDCED1B8f9e8a93df938690918c08BBF0D8DFDCED1B
Content-type: multipart/alternative; 
	Boundary="1__=08BBF0D8DFDCED1B8f9e8a93df938690918c08BBF0D8DFDCED1B"


--1__=08BBF0D8DFDCED1B8f9e8a93df938690918c08BBF0D8DFDCED1B
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: quoted-printable


Hi Jamie,

The "service" command doesn't work at all for upstart services (at leas=
t on
my machine). One problem I noticed in the init homepage, selecting modu=
les
and then clicking "start", "stop", or the "restart" button calls
mass_upstart.cgi, but the module homepage pulls both legacy SysV and
Upstart services, and mass_upstart.cgi only handles upstart services ri=
ght
now (assuming you change "service" to "initctl"). I'm not sure how to f=
ix
this problem. Any suggestions?

-David Lam



From:	"Jamie Cameron" <[email protected]>
To:	David Lam/Austin/IBM@IBMUS,
Cc:	Webmin development list <[email protected]>,
            David R Chiluk/Austin/IBM@IBMUS, Jamie L Dolan/Austin/IBM@I=
BMUS
Date:	07/27/2012 02:25 PM
Subject:	Re: [webmin-devel] Webmin



Hi David,

Thanks for those patches - however, regarding the one for the init modu=
le,
does using the service command not work at all? I recall that I chose t=
hat
over initctl as on some older Debian versions the initctl command wasn'=
t
available.

Perhaps alternately initctl should be used if it exists, otherwise fall=

back to the service command?


On 27/Jul/2012 08:25 David Lam <[email protected]> wrote ..


      Hi Jamie,

      I think these two patches are correct.

      init-lib.patch - Upstart services should call "initctl" instead o=
f
      "service".

      webmin-sshd.patch - Fixed typo and changed "rsa" to "dsa". Added
      'AUTHPRIV' to list of syslog facility codes.

      Thanks!

      (See attached file: webmin-sshd.patch)(See attached file:
      init-lib.patch)

      Inactive hide details for Jamie Cameron ---07/26/2012 04:20:53
      PM---You can just email them to me directly. Or submit them via J=
amie
      Cameron ---07/26/2012 04:20:53 PM---You can just email them to me=

      direc tly. Or submit them via github.com , in the webmin project.=

      Davi

      From: Jamie Cameron <[email protected]>
      To: Webmin development list <[email protected]=
>,
      Date: 07/26/2012 04:20 PM
      Subject: Re: [webmin-devel] Webmin





      You can just email them to me directly. Or submit them via
      github.com , in the webmin project.

      David Lam <[email protected]> wrote:


      Hi,

      First-time Sourceforge user here. I wanted to send some simple
      patches for Webmin, but wasn't sure what the best way was. Should=
 I
      post them on the Patches section, or should I send an email out o=
n
      the mailing list first?

      Thanks,
      David Lam
      -----------------------------------------------------------------=
-------------

      Live Security Virtual Conference
      Exclusive live event will cover all the ways today's security and=

      threat landscape has changed and how IT managers can respond.
      Discussions
      will include endpoint security, mobile security and the latest in=

      malware
      threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263=
/-
      Forwarded by the Webmin development list at [email protected]=
om
      To remove yourself from this list, go to
      http://lists.sourceforge.net/lists/listinfo/webadmin-devel





[attachment "webmin-sshd.patch" deleted by David Lam/Austin/IBM]
[attachment "init-lib.patch" deleted by David Lam/Austin/IBM]

=

--1__=08BBF0D8DFDCED1B8f9e8a93df938690918c08BBF0D8DFDCED1B
Content-type: text/html; charset=US-ASCII
Content-Disposition: inline
Content-transfer-encoding: quoted-printable

<html><body>
<p><tt><font size=3D"2">Hi Jamie, </font></tt><br>
<br>
<tt><font size=3D"2">The &quot;service&quot; command doesn't work at al=
l for upstart services (at least on my machine). One problem I noticed =
in the init homepage, selecting modules and then clicking &quot;start&q=
uot;, &quot;stop&quot;, or the &quot;restart&quot; button calls mass_up=
start.cgi, but the module homepage pulls both legacy SysV and Upstart s=
ervices, and mass_upstart.cgi only handles upstart services right now (=
assuming you change &quot;service&quot; to &quot;initctl&quot;). I'm no=
t sure how to fix this problem. Any suggestions?</font></tt><br>
<br>
<tt><font size=3D"2">-David Lam</font></tt><br>
<br>
<img width=3D"16" height=3D"16" src=3D"cid:1__=3D08BBF0D8DFDCED1B8f9e8a=
[email protected]" border=3D"0" alt=3D"Inactive hide details for &quot=
;Jamie Cameron&quot; ---07/27/2012 02:25:36 PM---   Hi David,    Thanks=
 for those patches - however, regar"><font size=3D"2" color=3D"#424282"=
 face=3D"sans-serif">&quot;Jamie Cameron&quot; ---07/27/2012 02:25:36 P=
M--- &nbsp; Hi David, &nbsp; &nbsp;Thanks for those patches - however, =
regarding the one for the init module,</font><br>
<br>
<font size=3D"1" color=3D"#5F5F5F" face=3D"sans-serif">From:	</font><fo=
nt size=3D"1" face=3D"sans-serif">&quot;Jamie Cameron&quot; &lt;jcamero=
[email protected]&gt;</font><br>
<font size=3D"1" color=3D"#5F5F5F" face=3D"sans-serif">To:	</font><font=
 size=3D"1" face=3D"sans-serif">David Lam/Austin/IBM@IBMUS, </font><br>=

<font size=3D"1" color=3D"#5F5F5F" face=3D"sans-serif">Cc:	</font><font=
 size=3D"1" face=3D"sans-serif">Webmin development list &lt;webadmin-de=
[email protected]&gt;, David R Chiluk/Austin/IBM@IBMUS, Jamie L=
 Dolan/Austin/IBM@IBMUS</font><br>
<font size=3D"1" color=3D"#5F5F5F" face=3D"sans-serif">Date:	</font><fo=
nt size=3D"1" face=3D"sans-serif">07/27/2012 02:25 PM</font><br>
<font size=3D"1" color=3D"#5F5F5F" face=3D"sans-serif">Subject:	</font>=
<font size=3D"1" face=3D"sans-serif">Re: [webmin-devel] Webmin</font><b=
r>
<hr width=3D"100%" size=3D"2" align=3D"left" noshade style=3D"color:#80=
91A5; "><br>
<br>
<br>
<font size=3D"3" face=3D"serif">Hi David,<br>
<br>
Thanks for those patches - however, regarding the one for the init modu=
le, does using the service command not work at all? I recall that I cho=
se that over initctl as on some older Debian versions the initctl comma=
nd wasn't available.<br>
<br>
Perhaps alternately initctl should be used if it exists, otherwise fall=
 back to the service command? </font>
<p><font size=3D"3" face=3D"serif">On 27/Jul/2012 08:25 David Lam &lt;d=
[email protected]&gt; wrote .. </font>
<ul style=3D"padding-left: 36pt"><br>
<font size=3D"2" face=3D"sans-serif">Hi Jamie,</font><font size=3D"3" f=
ace=3D"serif"><br>
</font><font size=3D"2" face=3D"sans-serif"><br>
I think these two patches are correct.</font><font size=3D"3" face=3D"s=
erif"><br>
</font><font size=3D"2" face=3D"sans-serif"><br>
init-lib.patch - Upstart services should call &quot;initctl&quot; inste=
ad of &quot;service&quot;. </font><font size=3D"3" face=3D"serif"><br>
</font><font size=3D"2" face=3D"sans-serif"><br>
webmin-sshd.patch - Fixed typo and changed &quot;rsa&quot; to &quot;dsa=
&quot;. Added 'AUTHPRIV' to list of syslog facility codes.</font><font =
size=3D"3" face=3D"serif"><br>
</font><font size=3D"2" face=3D"sans-serif"><br>
Thanks!</font><font size=3D"3" face=3D"serif"><br>
</font><font size=3D"3" face=3D"serif"><i><br>
(See attached file: webmin-sshd.patch)(See attached file: init-lib.patc=
h)</i></font><font size=3D"3" face=3D"serif"><br>
<br>
</font><img src=3D"cid:[email protected]" =
width=3D"16" height=3D"16" alt=3D"Inactive hide details for Jamie Camer=
on ---07/26/2012 04:20:53 PM---You can just email them to me directly. =
Or submit them via "><font size=3D"2" color=3D"#424282" face=3D"sans-se=
rif">Jamie Cameron ---07/26/2012 04:20:53 PM---You can just email them =
to me direc tly. Or submit them via github.com , in the webmin project.=
 &nbsp;Davi</font><font size=3D"3" face=3D"serif"><br>
</font><font size=3D"1" color=3D"#5F5F5F" face=3D"sans-serif"><br>
From: </font><font size=3D"1" face=3D"sans-serif">Jamie Cameron &lt;jca=
[email protected]&gt;</font><font size=3D"1" color=3D"#5F5F5F" face=3D"s=
ans-serif"><br>
To: </font><font size=3D"1" face=3D"sans-serif">Webmin development list=
 &lt;[email protected]&gt;, </font><font size=3D"1" =
color=3D"#5F5F5F" face=3D"sans-serif"><br>
Date: </font><font size=3D"1" face=3D"sans-serif">07/26/2012 04:20 PM</=
font><font size=3D"1" color=3D"#5F5F5F" face=3D"sans-serif"><br>
Subject: </font><font size=3D"1" face=3D"sans-serif">Re: [webmin-devel]=
 Webmin</font>
<p><hr width=3D"100%" size=3D"2" align=3D"left" noshade><font size=3D"3=
" face=3D"serif"><br>
<br>
<br>
You can just email them to me directly. Or submit them via github.com ,=
 in the webmin project. <br>
<br>
David Lam &lt;[email protected]&gt; wrote:</font>
<p><font size=3D"2" face=3D"sans-serif">Hi,<br>
<br>
First-time Sourceforge user here. I wanted to send some simple patches =
for Webmin, but wasn't sure what the best way was. Should I post them o=
n the Patches section, or should I send an email out on the mailing lis=
t first? <br>
<br>
Thanks,<br>
David Lam</font><tt><font size=3D"2">----------------------------------=
--------------------------------------------<br>
Live Security Virtual Conference<br>
Exclusive live event will cover all the ways today's security and <br>
threat landscape has changed and how IT managers can respond. Discussio=
ns <br>
will include endpoint security, mobile security and the latest in malwa=
re <br>
threats. </font></tt><a href=3D"http://www.accelacomm.com/jaw/sfrnl0424=
2012/114/50122263/"><tt><font size=3D"2" color=3D"#0000FF"><u>http://ww=
w.accelacomm.com/jaw/sfrnl04242012/114/50122263/</u></font></tt></a><tt=
><font size=3D"2">-<br>
Forwarded by the Webmin development list at [email protected]<br>=

To remove yourself from this list, go to</font></tt><tt><font size=3D"2=
" color=3D"#0000FF"><u><br>
</u></font></tt><a href=3D"http://lists.sourceforge.net/lists/listinfo/=
webadmin-devel"><tt><font size=3D"2" color=3D"#0000FF"><u>http://lists.=
sourceforge.net/lists/listinfo/webadmin-devel</u></font></tt></a>
<p><font size=3D"3" face=3D"serif">&nbsp;</font></ul>
<br>
<font size=3D"1" face=3D"sans-serif">[attachment &quot;webmin-sshd.patc=
h&quot; deleted by David Lam/Austin/IBM] [attachment &quot;init-lib.pat=
ch&quot; deleted by David Lam/Austin/IBM] </font>
<p></body></html>=


--1__=08BBF0D8DFDCED1B8f9e8a93df938690918c08BBF0D8DFDCED1B--

--0__=08BBF0D8DFDCED1B8f9e8a93df938690918c08BBF0D8DFDCED1B
Content-type: image/gif; 
	name="graycol.gif"
Content-Disposition: inline; filename="graycol.gif"
Content-ID: <[email protected]>
Content-transfer-encoding: base64

R0lGODlhEAAQAKECAMzMzAAAAP///wAAACH5BAEAAAIALAAAAAAQABAAAAIXlI+py+0PopwxUbpu
ZRfKZ2zgSJbmSRYAIf4fT3B0aW1pemVkIGJ5IFVsZWFkIFNtYXJ0U2F2ZXIhAAA7

--0__=08BBF0D8DFDCED1B8f9e8a93df938690918c08BBF0D8DFDCED1B--



--===============1334163486832334081==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
--===============1334163486832334081==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

-
Forwarded by the Webmin development list at [email protected]
To remove yourself from this list, go to
http://lists.sourceforge.net/lists/listinfo/webadmin-devel

--===============1334163486832334081==--