Use of isPrincipiaFolderish in plone.app.collection

Hi all,

We are finding some problems with integration between
plone.app.collection and collective.solr.

Without giving useless details of the problem, we found that all is
raised by this:
https://github.com/plone/plone.app.collection/blob/39e1f511996c9649719353af578c4278736edc38/plone/app/collection/collection.py#L170

Starting from plone.app.collection version 1.0.7 introduced a check of
item.isPrincipiaFolderish.

This is ok because item is a CatalogContentListingObject, that first
check for the element inside the catalog, then looks at the real
object.

We are wondering why don't check for "is_folderish", that is a catalog
index and metadata, so something we can also add to solr indexes (and
probably this will be faster).

Before preparing a pull request: anybody can find a good reason for
keeping isPrincipiaFolderish?


-- 
-- luca

twitter: http://twitter.com/keul
linkedin: http://linkedin.com/in/lucafbb
blog: http://blog.keul.it/

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk