Re: Use of isPrincipiaFolderish in plone.app.collection
ichimdav <[email protected]>
| Newsgroups | gmane.comp.web.zope.plone.devel |
|---|---|
| Message-ID | <[email protected]> |
https://github.com/plone/plone.app.collection/commit/05705f6c664a7fb116a0cb432d47478468e54b77 This check was added by me in the 1.0.7 release which can be seen from looking at the changes.txt You can see what was the previous code before my change which was very restrictive to only Folder content type. At the time when I checked isPrincipiaFolderish returned the correct response for an Archetypes Folder as well as a Dexterity Container and as such I've used it. If the metadata or index can be used then probably it makes sense to use it provided that the metadata is available when testing as well. I suggest you do a pull request with your change to the code and to the corresponding test ( or make a new one if needed ) and see what feedback you will get then. -- View this message in context: http://plone.293351.n2.nabble.com/Use-of-isPrincipiaFolderish-in-plone-app-collection-tp7569666p7569667.html Sent from the Core Developers mailing list archive at Nabble.com. ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk