Re: Use of isPrincipiaFolderish in plone.app.collection

On Fri, Jan 3, 2014 at 3:49 PM, ichimdav <[email protected]> wrote:
> https://github.com/plone/plone.app.collection/commit/05705f6c664a7fb116a0cb432d47478468e54b77
> This check was added by me in  the 1.0.7 release which can be seen from
> looking at the changes.txt
>
> You can see what was the previous code before my change which was very
> restrictive to only Folder content type.
>
> At the time when I checked isPrincipiaFolderish returned the correct
> response for an Archetypes Folder as well as a Dexterity Container and as
> such I've used it.
>
> If the metadata or index can be used then probably it makes sense to use it
> provided that the metadata is available when testing as well.
>
> I suggest you do a pull request with your change to the code and to the
> corresponding test ( or make a new one if needed ) and see what feedback you
> will get then.
>
>

Ok, we'll try is the changes and provide a pull request.

Thanks for the quick feedback

-- 
-- luca

twitter: http://twitter.com/keul
linkedin: http://linkedin.com/in/lucafbb
blog: http://blog.keul.it/

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk