Re: Where to fix Kupu bbb missing set_stripped_tags called by FilterControlPanelAdapter

On 2/26/14, 12:31 AM, Anthony Gerrard wrote:
> Hi,
>
> I'm facing a problem after upgrading my client's site to Plone 4.3. 
>  plone.app.controlpanel.filter.FilterControlPanelAdapter.stripped_tags 
> has the following block of code
>
>             if self.kupu_tool is not None:
>                 self.kupu_tool.set_stripped_tags(value)
>
> but plone.app.upgrade.kupu_bbb.PloneKupuLibraryTool has no method 
> set_stripped_tags.
>
> Please can someone explain to me what interface the kupu_bbb tool 
> should be providing?  The methods it does have are more than no-ops. 
> My initial thought was to simply tweak FilterControlPanelAdapter like so
>
>             if (self.kupu_tool is not None and
>                     hasattr(self.kupu_tool, 'set_stripped_tags')):
>                 self.kupu_tool.set_stripped_tags(value)
>
> but I can't help thinking the bug is in kupu_bbb.  I could add a no-op 
> method for set_stripped_tags.  Would that be OK?
>
Plone 4 no longer includes kupu (maybe it works if you install it as an 
add-on; I can't remember). It uses tinymce instead. The kupu_bbb tool is 
a temporary stub that should get removed when you run the upgrade steps.
David

------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk