Re: Plone 4.3.4, please get your pulls in

>From the comments on the pull request it seems someone already wrote a
migration step for plone.app.contenttypes assuming the change would be
merged:  Plone 5 shouldn't be an issue in this case.

I think it is too late to build in a migration step to plone.app.upgrade
for this but I don't see the harm in having the code available for other
people to migrate manually to blobs.

I haven't spent any time on the code yet - I'm planning to take a deeper
look over the next day or two and will report back.

Anthony


On 6 May 2014 08:05, Luca <[email protected]> wrote:

> On Mon, May 5, 2014 at 8:32 PM, Anthony Gerrard
> <[email protected]> wrote:
> > I have a new who needs this and can invest some time into it.  Presumably
> > it's uncontroversial so if I can get it working and tested we can merge
> it
> > this week?
> >
>
> No opposition at all, unluckily I've developer the branch on my
> personal fork (and event worst, on the master). But I think I can give
> write access to you or whoever (give me github usernames). Or: is
> possible to push to collective/some-new-branch? Don't know.
>
> But first: I suggest you to be sure that this will be accepted. Plone
> 5 will remove AT news items so probably it's a too deep change now.
>
>
>
> >
> > On 3 May 2014 08:11, Lucafbb <[email protected]> wrote:
> >>
> >>
> >>
> >> --
> >> -- luca
> >>
> >> Il giorno 02/mag/2014, alle ore 21:31, Anthony Gerrard
> >> <[email protected]> ha scritto:
> >>
> >> I'd really like this pull request reviewed to have news item images as
> >> blobs
> >>
> >> https://github.com/plone/plone.app.blob/pull/2
> >>
> >> Maybe it's too big to put in a minor release though?  This was a bit of
> an
> >> oversight in the original blob plip..
> >>
> >>
> >> Probably it's too late to see this happening. I started this PR on Plone
> >> 4.2 but it has never been merged (and I spent some hours during last
> years
> >> keeping the PR up to date, again without any result).
> >>
> >> Sorry but I've no more time/energy for this! :-)
> >>
> >>
> >>
> >> Anthony
> >>
> >>
> >> On 28 April 2014 21:11, Sean Upton <[email protected]> wrote:
> >>>
> >>> On Mon, Apr 28, 2014 at 6:11 AM, Eric Steele <[email protected]>
> >>> wrote:
> >>> > I'd like to start working on Plone 4.3.4. Please take some time to
> look
> >>> > over
> >>> > the list of open pull requests and comment/merge as warranted.
> >>>
> >>> Any comments on the two plone.supermodel pull requests?
> >>>
> >>>
> >>>
> https://github.com/plone/plone.supermodel/pull/5/files#diff-db23dcd814354c954091a9b90dbfd92aR7
> >>>
> >>>
> >>>
> https://github.com/plone/plone.supermodel/pull/7/files#diff-db23dcd814354c954091a9b90dbfd92aR7
> >>>
> >>> The latter is mine, and I am relying on it in production now to fix
> >>> https://github.com/plone/plone.app.dexterity/issues/49 -- I will try
> >>> to review and merge these both to master by week's end if no one else
> >>> cares to.
> >>>
> >>> Sean
> >>>
> >>>
> >>>
> ------------------------------------------------------------------------------
> >>> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
> >>> Instantly run your Selenium tests across 300+ browser/OS combos.  Get
> >>> unparalleled scalability from the best Selenium testing platform
> >>> available.
> >>> Simple to use. Nothing to install. Get started now for free."
> >>> http://p.sf.net/sfu/SauceLabs
> >>> _______________________________________________
> >>> Plone-developers mailing list
> >>> Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> >>> https://lists.sourceforge.net/lists/listinfo/plone-developers
> >>
> >>
> >>
> >>
> ------------------------------------------------------------------------------
> >> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
> >> Instantly run your Selenium tests across 300+ browser/OS combos.  Get
> >> unparalleled scalability from the best Selenium testing platform
> >> available.
> >> Simple to use. Nothing to install. Get started now for free."
> >> http://p.sf.net/sfu/SauceLabs
> >>
> >> _______________________________________________
> >> Plone-developers mailing list
> >> Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> >> https://lists.sourceforge.net/lists/listinfo/plone-developers
> >
> >
>
>
>
> --
> -- luca
>
> twitter: http://twitter.com/keul
> linkedin: http://linkedin.com/in/lucafbb
> blog: http://blog.keul.it/
>

------------------------------------------------------------------------------
Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
&#149; 3 signs your SCM is hindering your productivity
&#149; Requirements for releasing software faster
&#149; Expert tips and advice for migrating your SCM now
http://p.sf.net/sfu/perforce

_______________________________________________
Plone-developers mailing list
Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/plone-developers