Re: Porting tests to plone.app.testing and removal of legacy packages

Well, tests on the branch were green. So why after merge not on master?

If this all fails that hard we need a better process. Merging is always 
a huge PITA at the moment.

We can try now to fix the stuff on masters or we take days until all is 
merged piece by piece. Each test run takes ages. That way we never get 
plone 5 out of the door. Probability to break the build from even green 
branches is bigger than that it works. This a incredibly turn-off.

Jens

On 2015-01-27 22:04, Timo Stollenwerk wrote:
> Am 27.01.15 um 19:20 schrieb Gil Forcada:
>> I can already hear Timo saying "one at a time please (merge PR)!!!"
>
> Exactly. I already started to merge the pull requests (one at a time).
>
> I stopped because this issue needs to be solved before we can continue:
>
> https://github.com/plone/plone.namedfile/pull/10/files#r23127670
>
> As said many times before, we have serious test isolation problems that
> lead to unexpected behavior. Just merging lots of pull requests at the
> same time and expecting it to work it wishful thinking, that is not
> going to happen.
>
> @jensens: I'd suggest that you revert all your merges immediately, I
> sincerly doubt that this is going to work. We have to merge one pull
> request at a time making sure that those tests work in full test
> isolation first. If that works we can re-add the package tests to a
> testing group.
>
>> There seems to be some errors with them, let's wait until all jobs are
>> done though...
>>
>> El dt 27 de 01 de 2015 a les 17:59 +0100, en/na Jens W. Klein va
>> escriure:
>>> On 2015-01-27 16:24, Tom Gross wrote:
>>>> Hi all
>>>>
>>>>
>>>> As you might have seen already, the Jenkins Job with all (the non AT)
>>>> packages has gone green:
>>>> http://jenkins.plone.org/job/plip-plone-app-testing/
>>>>
>>>> Can someone please merge the following PR:
>>>>
>>>>
>>>> plone.app.versioningbehavior
>>> merged
>>>
>>>> plone.outputfilters
>>> is the issue with the failing test referenced at
>>> https://github.com/plone/plone.outputfilters/pull/10
>>> solved?
>
> As far as I understand other pull requests depend on this change.
>
>>>> Products.CMFEditions
>>> merged
>>>
>>>> plone.app.blob
>>> merged
>>>
>>>> plone.app.controlpanel
>>> merged
>
> I doubt that it makes sense to merge this pull request.
> plone.app.controlpanel is not going to have any tests left as soon as we
> finished moving all control panels to CMFPlone.
>
> Timo
>
> ------------------------------------------------------------------------------
> Dive into the World of Parallel Programming. The Go Parallel Website,
> sponsored by Intel and developed in partnership with Slashdot Media, is your
> hub for all things parallel software development, from weekly thought
> leadership blogs to news, videos, case studies, tutorials and more. Take a
> look and join the conversation now. http://goparallel.sourceforge.net/
>


-- 
Klein & Partner KG, member of BlueDynamics Alliance


------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/