Re: AliasToBeanConstructorResultTransformer Improvement
"Ayende Rahien" <[email protected]> Wed, 3 Sep 2008 18:59:04 -0400
| Newsgroups | gmane.comp.windows.dotnet.nhibernate.devel |
|---|---|
| Message-ID | <[email protected]> |
--===============1228973183== Content-Type: multipart/alternative; boundary="----=_Part_18871_12334644.1220482744960" ------=_Part_18871_12334644.1220482744960 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Yes, that is a common optimization, and we are using this extensively in the Getter/Setter implementation On Wed, Sep 3, 2008 at 6:46 PM, Jonathon Gottschalk < [email protected]> wrote: > Hello, I am posting this message here at Fabio's request. I made an > improved version of one of the NH classes utilizing IL code and he wanted > feedback from the other developers and contributers on the matter. You can > see my original JIRA post at the following URL: > > http://jira.nhibernate.org/browse/NH-1433 > > Basically, I modified the class to remove the slow reflection call with a > direct IL code call, which resulted in a marked performance increase when > utilizing the new keyword. HQL queries that utilize the new keyword (or any > operation that causes an instance of the > AliasToBeanConstructorResultTransformer) would be affected by this patch. I > inserted proper security checks to make sure the IL code method can actually > be used in situations where the current security context might not allow it > (such as Medium Trust), and if the security context does not allow it simply > revert to the standard reflection-based method that it currently uses. > > I am more than happy to answer any questions regarding this patch. Thanks. > > ------------------------------ > See how Windows connects the people, information, and fun that are part of > your life. See Now<http://clk.atdmt.com/MRT/go/msnnkwxp1020093175mrt/direct/01/> > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > Build the coolest Linux based applications with Moblin SDK & win great > prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Nhibernate-development mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/nhibernate-development > > ------=_Part_18871_12334644.1220482744960 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline <div dir="ltr">Yes, that is a common optimization, and we are using this extensively in the Getter/Setter implementation<br><br><div class="gmail_quote">On Wed, Sep 3, 2008 at 6:46 PM, Jonathon Gottschalk <span dir="ltr"><<a href="mailto:[email protected]">[email protected]</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"> <div>Hello, I am posting this message here at Fabio's request. I made an improved version of one of the NH classes utilizing IL code and he wanted feedback from the other developers and contributers on the matter. You can see my original JIRA post at the following URL:<br> <br> <a href="http://jira.nhibernate.org/browse/NH-1433" target="_blank">http://jira.nhibernate.org/browse/NH-1433</a><br> <br> Basically, I modified the class to remove the slow reflection call with a direct IL code call, which resulted in a marked performance increase when utilizing the new keyword. HQL queries that utilize the new keyword (or any operation that causes an instance of the AliasToBeanConstructorResultTransformer) would be affected by this patch. I inserted proper security checks to make sure the IL code method can actually be used in situations where the current security context might not allow it (such as Medium Trust), and if the security context does not allow it simply revert to the standard reflection-based method that it currently uses.<br> <br> I am more than happy to answer any questions regarding this patch. Thanks.<br><br><hr>See how Windows connects the people, information, and fun that are part of your life. <a href="http://clk.atdmt.com/MRT/go/msnnkwxp1020093175mrt/direct/01/" target="_blank">See Now</a></div> <br>-------------------------------------------------------------------------<br> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge<br> Build the coolest Linux based applications with Moblin SDK & win great prizes<br> Grand prize is a trip for two to an Open Source event anywhere in the world<br> <a href="http://moblin-contest.org/redirect.php?banner_id=100&url=/" target="_blank">http://moblin-contest.org/redirect.php?banner_id=100&url=/</a><br>_______________________________________________<br> Nhibernate-development mailing list<br> <a href="mailto:[email protected]">[email protected]</a><br> <a href="https://lists.sourceforge.net/lists/listinfo/nhibernate-development" target="_blank">https://lists.sourceforge.net/lists/listinfo/nhibernate-development</a><br> <br></blockquote></div><br></div> ------=_Part_18871_12334644.1220482744960-- --===============1228973183== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ --===============1228973183== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Nhibernate-development mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nhibernate-development --===============1228973183==--