[jedit:plugin-central-submission] Re: #1076 LSP
Eric Le Lay via jEdit-devel <[email protected]>
| Newsgroups | gmane.editors.jedit.devel |
|---|---|
| Message-ID | </p/jedit/plugin-central-submission/1076/b06985ea7521e2020195b16811bd6a02e6fdd656.plugin-central-submission@jedit.p.sourceforge.net> |
Really cool, thanks! I've played a bit with it and here are my remarks.
Only **blocking** questions that must be answered before initial release are related to bundled libs and dependencies, otherwise we can always expand in another release shortly.
Errors:
**blocking** The plugin depends on Console plugin for the print() macro in downloadEclipse.bsh.
**blocking** Deps:
- I don't like that common-codecs is bundled but it seems LSP is the first plugin using it.
- shall we have a LSP-deps plugin with bundled libraries that we can upgrade separately or depend on in other plugins? This would make sense if a different plugin implemented LSP but this would actually be bad: better improve on this one. Also how do you plan extensibility: for instance if I want to implement the debugger part of a client, would I be able to create another plugin or do we put everything in the same plugin?
User niceties:
- Maybe start server could check if the server is installed and then display an explicit error when not.
- Show subprocess output when exiting in error: I first had missing python3 command error; then "only supports java17" error.
- `WARNING: Unsupported notification method: language/status` appears in the logs when jdtls is starting
Code:
- Some code in Utils.java could be replaced with jEdit own code
- some algorithms don't seem optimal (eg DiagnosticPainter storing icon for each line) but I'm not familiar with the hot code paths to say if it's good enough or to be fixed.
Behaviour:
- I got a stuck task in TaskMonitor when playing with jdtls. Its name is `lsp.Server$$Lambda...` so I can't tell what got stuck.
- how do I see the message associated with a diagnostics icon in the ruler? If ErrorList supported "info" errors, would it make sense to only use error list painter? Do other plugin show such icons? It rings a bell but I can't remember right now.
- I've got an issue on fresh install where the buffer is always a non-project file...
- it seems diagnostics icons don't move when I add a line in the editor before it.
Doc:
The awful builtin HTML viewer renders black text on a dark blue background: not the best legible contrast ;-)
jdtls requires python3 and java 17. Should be documented.
---
**[plugin-central-submission:#1076] LSP**
**Status:** open
**Group:** None
**Created:** Wed Jun 14, 2023 02:09 AM UTC by Damien
**Last Updated:** Sun Aug 06, 2023 10:42 AM UTC
**Owner:** nobody
**Announcement:** Initial Plugin Central release
**Name:** LSP
**Version:** 0.1
**Requirements:**
- JDK 11
- jEdit 5.5.0
- plugin: ErrorList 2.4.0
- plugin: SideKick 1.8
- plugin: ProjectViewer 3.6
- bundled library: org.eclipse.lsp4j 0.18.0
- bundled library: org.eclipse.lsp4j.jsonrpc 0.18.0
- bundled library: org.eclipse.xtext.xbase.lib 2.28.0
- bundled library: gson 2.9.1
- bundled library: guava 31.1-jre
- bundled library: commonmark 0.20.0
- bundled library: commons-compress 1.23.0
All bundled libraries are downloaded from Maven Central using Ivy.
**Source Code:** https://git.sr.ht/~damien/jedit-lsp/tree/v0.1
**Short Description:** This plugin turns jEdit into a Language Server Protocol (LSP) client, which provides a number of IDE-like features by running and interacting with LSP servers.
**Long Description:**
~~~
<html>
<p>This plugin turns jEdit into a Language Server Protocol (LSP) client, which provides a number of IDE-like features by running and interacting with LSP servers.</p>
<p>For more information on the protocol, see: https://microsoft.github.io/language-server-protocol/</p>
<p>To see a list of available LSP servers, see: https://microsoft.github.io/language-server-protocol/implementors/servers/</p>
<p>The LSP protocol supports many, many features, and this plugin only implements a tiny subset of them. Support for more can be added easily, limited primarily by time and effort.</p>
</html>
~~~
---
Sent from sourceforge.net because [email protected] is subscribed to https://sourceforge.net/p/jedit/plugin-central-submission/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/plugin-central-submission/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
--
-----------------------------------------------
jEdit Developers' List
[email protected]
https://lists.sourceforge.net/lists/listinfo/jedit-devel