[jedit:plugin-central-submission] #1076 LSP
Damien via jEdit-devel <[email protected]>
| Newsgroups | gmane.editors.jedit.devel |
|---|---|
| Message-ID | </p/jedit/plugin-central-submission/1076/880a78a1626ed7a15a55a57b837a982e8aee4f6d.plugin-central-submission@jedit.p.sourceforge.net> |
Hey Eric, thanks for the feedback!
I also don't have a _lot_ of time to play around with stuff like this, but I had some time in between jobs to take a crack at it, and wanted to publish my results. So no worries at all on the delay, and thanks for helping to maintain jEdit's plugin ecosystem!
1. In terms of the Console dependency, I just pushed a small change to remove the need for that dependency by using `System.out.println()` directly, rather than `print()`.
2. For the deps, I would lean towards the simplest possible solution, at least initially. I don't really foresee the need for additional LSP plugins (maybe a separate one to support the Debug Adapter Protocol that depends on LSP), and the dependencies of LSP shouldn't need to be updated very often. Breaking the LSP plugin up into multiple, to me, seems like it would increase the maintenance burden for not much benefit. I'm happy to hear of any scenarios you might be thinking of, though, where this might be more beneficial.
3. I agree with most of your comments on user niceties. The only comment I have is that the plugin is designed to work with system-installed servers as well; the installation functionality is just a convenience for anyone who doesn't already have the server available. So, I wouldn't want to necessarily show an error if the server was installed through some other means. I do think the "server couldn't be started" error could be made more visible, though it also shouldn't be too annoying either.
4. Can you be more specific about which functions in Utils.java could be replaced with jEdit functions?
5. The ProjectViewer dependency was intended to provide a language-agnostic way to determine the project's "root," which many other editors do manually via file detection. But, I agree that I think I have seen some issues with that flow, so I may consider introducing that type of behavior as a fallback. For Java, that would be looking for something like a settings.gradle, pom.xml, etc.
Lastly, should any changes here be used to re-tag 0.1 as long as it's before the actual release? Or should I instead begin introducing new tags like 0.1.1?
---
**[plugin-central-submission:#1076] LSP**
**Status:** open
**Group:** None
**Created:** Wed Jun 14, 2023 02:09 AM UTC by Damien
**Last Updated:** Sun Aug 06, 2023 05:44 PM UTC
**Owner:** nobody
**Announcement:** Initial Plugin Central release
**Name:** LSP
**Version:** 0.1
**Requirements:**
- JDK 11
- jEdit 5.5.0
- plugin: ErrorList 2.4.0
- plugin: SideKick 1.8
- plugin: ProjectViewer 3.6
- bundled library: org.eclipse.lsp4j 0.18.0
- bundled library: org.eclipse.lsp4j.jsonrpc 0.18.0
- bundled library: org.eclipse.xtext.xbase.lib 2.28.0
- bundled library: gson 2.9.1
- bundled library: guava 31.1-jre
- bundled library: commonmark 0.20.0
- bundled library: commons-compress 1.23.0
All bundled libraries are downloaded from Maven Central using Ivy.
**Source Code:** https://git.sr.ht/~damien/jedit-lsp/tree/v0.1
**Short Description:** This plugin turns jEdit into a Language Server Protocol (LSP) client, which provides a number of IDE-like features by running and interacting with LSP servers.
**Long Description:**
~~~
<html>
<p>This plugin turns jEdit into a Language Server Protocol (LSP) client, which provides a number of IDE-like features by running and interacting with LSP servers.</p>
<p>For more information on the protocol, see: https://microsoft.github.io/language-server-protocol/</p>
<p>To see a list of available LSP servers, see: https://microsoft.github.io/language-server-protocol/implementors/servers/</p>
<p>The LSP protocol supports many, many features, and this plugin only implements a tiny subset of them. Support for more can be added easily, limited primarily by time and effort.</p>
</html>
~~~
---
Sent from sourceforge.net because [email protected] is subscribed to https://sourceforge.net/p/jedit/plugin-central-submission/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/plugin-central-submission/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
--
-----------------------------------------------
jEdit Developers' List
[email protected]
https://lists.sourceforge.net/lists/listinfo/jedit-devel