Re: [PATCH] new feature: horizontal scrolling of full screen
Xylia Allegretta <[email protected]> Wed, 7 Jan 2026 20:04:31 +0000
| Newsgroups | gmane.editors.nano.devel |
|---|---|
| Message-ID | <CAE7GgQ9mp9nwVLiFx3y7w3n_5uq2zWX+nbkt8B-cUCxcamp+7A@mail.gmail.com> |
On Wed, Jan 7, 2026 at 3:18 PM Benno Schulenberg <[email protected]> wrote: > However, did you see the "smooth horizontal scrolling" patch that I > posted three days ago? It wasn't meant as an additional patch to > yours, but as an alternative. What do you think of it? In my eyes > it is simpler and easier to understand. And much shorter too. The > current version of your patch adds more than a hundred lines, whereas > the second version of my patch, which I'll post in a few minutes, adds > just over 40 lines. This is the implementation I intend to merge. > Do you see any issues with it? If yes, which? And are there any > reasons why your implementation would be preferable? Testing out your implementation, the only problems I've noticed so far are that <Backspace> doesn't scroll the screen backwards and that opening the help text doesn't reset the scroll amount, cutting off the beginning of the text. Assuming those are fixed, though, I don't think there's really much of a difference between our implementations in terms of user experience, so to be honest, it doesn't much matter to me which one you merge. As long as the feature gets added, and as long as it works, that's good enough for me. -Xylia Allegretta.