Re: [PATCH] Add new "Open new Tab"-Tab to the tab bar

On Tue, Oct 27, 2009 at 12:50 AM, TK Soh <[email protected]> wrote:
> On Mon, Oct 26, 2009 at 11:54 PM, TK Soh <[email protected]> wrote:
>> On Mon, Oct 26, 2009 at 11:35 AM, Bert Wesarg
>> <bert.wesarg-gM/[email protected]> wrote:
>>> On Mon, Oct 26, 2009 at 09:31, Bert Wesarg <bert.wesarg-gM/[email protected]> wrote:
>>>> On Mon, Oct 26, 2009 at 09:14, TK Soh <[email protected]> wrote:
>>>>> On Mon, Oct 26, 2009 at 8:09 AM, Bert Wesarg <bert.wesarg-gM/[email protected]> wrote:
>>>>>> It looks like the free Mercurial repo service freehg.org is down, so I
>>>>>> need to look for a new one. I remember barely that you used the HG
>>>>>> mirror, so do you have a suggestion?
>>>>>
>>>>> You can use bitbucket.org to host mercurial repos for free, which is
>>>>> where a lot of mercurial projects are hosted. It's a github for git.
>>>> Thanks, I will create a repo there and update my scripts. Will report
>>>> back if its running.
>>> TK,
>>> can you please try it out:
>>>
>>> http://bitbucket.org/bert.wesarg/nedit/
>>
>> Clone and build went well on my Fedora 9 box, with OM 2.3.0. Thanks.
>
> I tried your patch to both tip and BETA-5-6 branch, but failed to make:
>
> window.c: In function 'raiseTabCB':
> window.c:4721: error: too many arguments to function 'EditNewFile'
>
> What did I misss?

FYI, I took out the last argv, and it seem to work now:

[r28629@protogen: ~/NEdit/wesarg]% hg diff
diff --git a/source/window.c b/source/window.c
--- a/source/window.c
+++ b/source/window.c
@@ -4718,7 +4718,7 @@
         WindowInfo *window = lastFocusDocument;
         if (!window)
             window = TabToWindow(tabList[cbs->pos - 2]);
-        EditNewFile(window, NULL, False, NULL, window->path, False);
+        EditNewFile(window, NULL, False, NULL, window->path);
         CheckCloseDim();
         cbs->allowActivate = 0;
     }

The '+' tab has the same width as the others, but I understand this is
just a first draft. Nice work otherwise :-)
-- 
NEdit Discuss mailing list - [email protected]
http://www.nedit.org/mailman/listinfo/discuss