Re: [PATCH] Add new "Open new Tab"-Tab to the tab bar

Bert Wesarg <bert.wesarg-gM/[email protected]>
Newsgroups gmane.editors.nedit.user
Message-ID <[email protected]>
On Tue, Oct 27, 2009 at 02:22, TK Soh <[email protected]> wrote:
> On Tue, Oct 27, 2009 at 12:50 AM, TK Soh <[email protected]> wrote:
>> I tried your patch to both tip and BETA-5-6 branch, but failed to make:
>>
>> window.c: In function 'raiseTabCB':
>> window.c:4721: error: too many arguments to function 'EditNewFile'
>>
>> What did I misss?
>
> FYI, I took out the last argv, and it seem to work now:
>
> [r28629@protogen: ~/NEdit/wesarg]% hg diff
> diff --git a/source/window.c b/source/window.c
> --- a/source/window.c
> +++ b/source/window.c
> @@ -4718,7 +4718,7 @@
>         WindowInfo *window = lastFocusDocument;
>         if (!window)
>             window = TabToWindow(tabList[cbs->pos - 2]);
> -        EditNewFile(window, NULL, False, NULL, window->path, False);
> +        EditNewFile(window, NULL, False, NULL, window->path);
>         CheckCloseDim();
>         cbs->allowActivate = 0;
>     }
That should be correct, thanks.

>
> The '+' tab has the same width as the others, but I understand this is
> just a first draft. Nice work otherwise :-)
Now comes the motif experts into play, someone around? I will look
today into it, how I can beautify this tab.

Bert

> --
> NEdit Discuss mailing list - [email protected]
> http://www.nedit.org/mailman/listinfo/discuss
>
-- 
NEdit Discuss mailing list - [email protected]
http://www.nedit.org/mailman/listinfo/discuss
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.