[vim/vim] popup: virtual text is not redrawn when a text property changes (PR #20931)

----==_mimepart_6a70a39d8e2fa_109116837519d
Content-Type: text/plain; charset="UTF-8"

```
Problem:  Adding or removing a text property in the buffer of a popup
          window does not update the popup on the screen.  The old
          virtual text stays visible until something else causes a
          redraw.
Solution: Also mark popup windows displaying the buffer for redrawing in
          redraw_buf_later().
```

related: #19297
https://github.com/vim/vim/pull/19297#issuecomment-5164834271
You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/20931

-- Commit Summary --

  * popup: virtual text is not redrawn when a text property changes

-- File Changes --

    M src/drawscreen.c (9)
    A src/testdir/dumps/Test_popupwin_textprop_redraw_1.dump (10)
    A src/testdir/dumps/Test_popupwin_textprop_redraw_2.dump (10)
    M src/testdir/test_popupwin.vim (37)

-- Patch Links --

https://github.com/vim/vim/pull/20931.patch
https://github.com/vim/vim/pull/20931.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/vim/vim/pull/20931
You are receiving this because you are subscribed to this thread.

Message ID: <vim/vim/pull/[email protected]>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/20931%40github.com.

----==_mimepart_6a70a39d8e2fa_109116837519d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<pre class=3D"notranslate"><code class=3D"notranslate">Problem:  Adding or =
removing a text property in the buffer of a popup
          window does not update the popup on the screen.  The old
          virtual text stays visible until something else causes a
          redraw.
Solution: Also mark popup windows displaying the buffer for redrawing in
          redraw_buf_later().
</code></pre>
<p dir=3D"auto">related: <a class=3D"issue-link js-issue-link" data-error-t=
ext=3D"Failed to load title" data-id=3D"3879197614" data-permission-text=3D=
"Title is private" data-url=3D"https://github.com/vim/vim/issues/19297" dat=
a-hovercard-type=3D"pull_request" data-hovercard-url=3D"/vim/vim/pull/19297=
/hovercard" href=3D"https://github.com/vim/vim/pull/19297">#19297</a><br>
<a class=3D"issue-link js-issue-link" data-error-text=3D"Failed to load tit=
le" data-id=3D"3879197614" data-permission-text=3D"Title is private" data-u=
rl=3D"https://github.com/vim/vim/issues/19297" data-hovercard-type=3D"pull_=
request" data-hovercard-url=3D"/vim/vim/pull/19297/hovercard?comment_id=3D5=
164834271&amp;comment_type=3Dissue_comment" href=3D"https://github.com/vim/=
vim/pull/19297#issuecomment-5164834271">#19297 (comment)</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>&nbsp;&nbsp;<a href=3D'https://github.com/vim/vim/pull/20931'>https://gi=
thub.com/vim/vim/pull/20931</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href=3D"https://github.com/vim/vim/pull/20931/commits/1faedd6048ee=
d6c2d4e0887b0a111534c1e063a0" class=3D"commit-link">1faedd6</a>  popup: vir=
tual text is not redrawn when a text property changes</li>
</ul>

<h4 style=3D"display: inline-block">File Changes </h4> <p style=3D"display:=
 inline-block">(<a href=3D"https://github.com/vim/vim/pull/20931/files">4&n=
bsp;files</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href=3D"https://github.com/vim/vim/pull/20931/files#diff-f6356031624=
eb43f2abdcb3c781a3dbf6fb8e9eda73ea8e9de86746d6df2c30d">src/drawscreen.c</a>
    (9)
  </li>
  <li>
    <strong>A</strong>
    <a href=3D"https://github.com/vim/vim/pull/20931/files#diff-55d2ec328e8=
064fee5db6427858be1676f5835c1284fd20c8c1eb949a645a1a4">src/testdir/dumps/Te=
st_popupwin_textprop_redraw_1.dump</a>
    (10)
  </li>
  <li>
    <strong>A</strong>
    <a href=3D"https://github.com/vim/vim/pull/20931/files#diff-f0b26dd3295=
4184e56f9e46f5d0e5291d257e3bc1fe2fa7f7e5a27c98b794b86">src/testdir/dumps/Te=
st_popupwin_textprop_redraw_2.dump</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href=3D"https://github.com/vim/vim/pull/20931/files#diff-4846906bd04=
ea246c4a36c691051a7df812d205313c01b35d050135993f4b0a3">src/testdir/test_pop=
upwin.vim</a>
    (37)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href=3D'https://github.com/vim/vim/pull/20931.patch'>https://githu=
b.com/vim/vim/pull/20931.patch</a></li>
  <li><a href=3D'https://github.com/vim/vim/pull/20931.diff'>https://github=
.com/vim/vim/pull/20931.diff</a></li>
</ul>

<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&mda=
sh;<br />Reply to this email directly, <a href=3D"https://github.com/vim/vi=
m/pull/20931">view it on GitHub</a>, or <a href=3D"https://github.com/notif=
ications/unsubscribe-auth/ACY5DGEHF4H3WZYPOUKQUND5ICNR3AVCNFSNUABEKJSXA33TN=
F2G64TZHM2DAOJZG42DQMR3JFZXG5LFHM2TANJQHAYTANRWHCQXMAQ">unsubscribe</a>.<br=
 />Triage notifications, keep track of coding agent tasks and review pull r=
equests on the go with GitHub Mobile for <a href=3D"https://github.com/noti=
fications/mobile/ios/ACY5DGFHOMNKIMVPCZ35CU35ICNR3A5CNFSNUABEM5UWIORPF5TWS5=
BNNB2WEL2QOVWGYUTFOF2WK43UF42DCOJVGE2TMMJZGWTHEZLBONXW5KTTOVRHGY3SNFRGKZFFM=
V3GK3TUVJTG633UMVZF62LPOM">iOS</a> and <a href=3D"https://github.com/notifi=
cations/mobile/android/ACY5DGB3S7VXBAB3TSGJDGD5ICNR3A5CNFSNUABEM5UWIORPF5TW=
S5BNNB2WEL2QOVWGYUTFOF2WK43UF42DCOJVGE2TMMJZGWTHEZLBONXW5KTTOVRHGY3SNFRGKZF=
FMV3GK3TUVZTG633UMVZF6YLOMRZG62LE">Android</a>. Download it today!
<br />You are receiving this because you are subscribed to this thread.<img=
 src=3D"https://github.com/notifications/beacon/ACY5DGDKGYC4LMONTY2J7VD5ICN=
R3BFCNFSM6AAAAAC4YVPLQWWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHQAA=
AAAEWQ2QJMUZZGKYLTN5XKU43VMJZWG4TJMJSWI.gif" height=3D"1" width=3D"1" alt=
=3D"" /><span style=3D"color: transparent; font-size: 0; display: none; vis=
ibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-wid=
th: 0; max-height: 0; mso-hide: all">Message ID: <span>&lt;vim/vim/pull/209=
31</span><span>@</span><span>github</span><span>.</span><span>com&gt;</span=
></span></p>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/vim/vim/pull/20931",
"url": "https://github.com/vim/vim/pull/20931",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>

<p></p>

-- <br />
-- <br />
You received this message from the &quot;vim_dev&quot; maillist.<br />
Do not top-post! Type your reply below the text you are replying to.<br />
For more information, visit <a href=3D"http://www.vim.org/maillist.php">htt=
p://www.vim.org/maillist.php</a><br />
<br />
--- <br />
You received this message because you are subscribed to the Google Groups &=
quot;vim_dev&quot; group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:[email protected]">vim_dev+uns=
[email protected]</a>.<br />
To view this discussion visit <a href=3D"https://groups.google.com/d/msgid/=
vim_dev/vim/vim/pull/20931%40github.com?utm_medium=3Demail&utm_source=3Dfoo=
ter">https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/20931%40github.=
com</a>.<br />

----==_mimepart_6a70a39d8e2fa_109116837519d--