Re: [vim/vim] Fix Popup Redraw Issues and Borderhighlight Clearing (PR #19297)

----==_mimepart_6a70a5f0eb88f_b11168549443
Content-Type: text/plain; charset="UTF-8"

h-east left a comment (vim/vim#19297)

@mmrwoods 
Reproduced.  `prop_add()` and `prop_remove()` end in `redraw_buf_later()`,
which only walks `FOR_ALL_WINDOWS()`.  Popup windows are on a separate list,
so they never get marked and the new `popup_need_redraw()` check in
`update_screen()` skips them.  It works only when something else redraws a
normal window in the same screen update.

`prop_add()` has no zindex option, so your value was ignored without an error.

Fix: mark popup windows in `redraw_buf_later()` too.  PR #20931.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/vim/vim/pull/19297#issuecomment-5167676074
You are receiving this because you are subscribed to this thread.

Message ID: <vim/vim/pull/19297/[email protected]>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/19297/c5167676074%40github.com.

----==_mimepart_6a70a5f0eb88f_b11168549443
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div style=3D"display: flex; flex-wrap: wrap; white-space: pre-wrap; align-=
items: center; "><img height=3D"20" width=3D"20" style=3D"border-radius:50%=
; margin-right: 4px;" decoding=3D"async" src=3D"https://avatars.githubuserc=
ontent.com/u/518808" /><strong>h-east</strong> left a comment <a href=3D"ht=
tps://github.com/vim/vim/pull/19297#issuecomment-5167676074">(vim/vim#19297=
)</a></div>
<p dir=3D"auto"><a class=3D"user-mention notranslate" data-hovercard-type=
=3D"user" data-hovercard-url=3D"/users/mmrwoods/hovercard" data-octo-click=
=3D"hovercard-link-click" data-octo-dimensions=3D"link_type:self" href=3D"h=
ttps://github.com/mmrwoods">@mmrwoods</a><br>
Reproduced.  <code class=3D"notranslate">prop_add()</code> and <code class=
=3D"notranslate">prop_remove()</code> end in <code class=3D"notranslate">re=
draw_buf_later()</code>,<br>
which only walks <code class=3D"notranslate">FOR_ALL_WINDOWS()</code>.  Pop=
up windows are on a separate list,<br>
so they never get marked and the new <code class=3D"notranslate">popup_need=
_redraw()</code> check in<br>
<code class=3D"notranslate">update_screen()</code> skips them.  It works on=
ly when something else redraws a<br>
normal window in the same screen update.</p>
<p dir=3D"auto"><code class=3D"notranslate">prop_add()</code> has no zindex=
 option, so your value was ignored without an error.</p>
<p dir=3D"auto">Fix: mark popup windows in <code class=3D"notranslate">redr=
aw_buf_later()</code> too.  PR <a class=3D"issue-link js-issue-link" data-e=
rror-text=3D"Failed to load title" data-id=3D"5050810668" data-permission-t=
ext=3D"Title is private" data-url=3D"https://github.com/vim/vim/issues/2093=
1" data-hovercard-type=3D"pull_request" data-hovercard-url=3D"/vim/vim/pull=
/20931/hovercard" href=3D"https://github.com/vim/vim/pull/20931">#20931</a>=
.</p>

<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&mda=
sh;<br />Reply to this email directly, <a href=3D"https://github.com/vim/vi=
m/pull/19297#issuecomment-5167676074">view it on GitHub</a>, or <a href=3D"=
https://github.com/notifications/unsubscribe-auth/ACY5DGERUO7H4UGUWPEUPDT5I=
COXBAVCNFSNUABEKJSXA33TNF2G64TZHM2DAOJZG42DQMR3JFZXG5LFHMZTQNZZGE4TONRRGSQX=
MAQ">unsubscribe</a>.<br />Triage notifications, keep track of coding agent=
 tasks and review pull requests on the go with GitHub Mobile for <a href=3D=
"https://github.com/notifications/mobile/ios/ACY5DGEH2W3RQG7TZQIRKAT5ICOXBA=
5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJWG43DONRQG42KM4TFM=
FZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ">iOS</a> and <a href=3D=
"https://github.com/notifications/mobile/android/ACY5DGAXHQO6X7QFPKODQWT5IC=
OXBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJWG43DONRQG42KM=
4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ">Android</a>.=
 Download it today!
<br />You are receiving this because you are subscribed to this thread.<img=
 src=3D"https://github.com/notifications/beacon/ACY5DGB4KZRFMTUR3IMDZJT5ICO=
XBBFCNFSM6AAAAAC4YHAX56WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3=
TUL5UWJTYAAAAACNAEPKVKM4TFMFZW63VKON2WE43DOJUWEZLE.gif" height=3D"1" width=
=3D"1" alt=3D"" /><span style=3D"color: transparent; font-size: 0; display:=
 none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: =
0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span>&lt;vim/vi=
m/pull/19297/c5167676074</span><span>@</span><span>github</span><span>.</sp=
an><span>com&gt;</span></span></p>

<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/vim/vim/pull/19297#issuecomment-5167676074",
"url": "https://github.com/vim/vim/pull/19297#issuecomment-5167676074",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>

<p></p>

-- <br />
-- <br />
You received this message from the &quot;vim_dev&quot; maillist.<br />
Do not top-post! Type your reply below the text you are replying to.<br />
For more information, visit <a href=3D"http://www.vim.org/maillist.php">htt=
p://www.vim.org/maillist.php</a><br />
<br />
--- <br />
You received this message because you are subscribed to the Google Groups &=
quot;vim_dev&quot; group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:[email protected]">vim_dev+uns=
[email protected]</a>.<br />
To view this discussion visit <a href=3D"https://groups.google.com/d/msgid/=
vim_dev/vim/vim/pull/19297/c5167676074%40github.com?utm_medium=3Demail&utm_=
source=3Dfooter">https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/192=
97/c5167676074%40github.com</a>.<br />

----==_mimepart_6a70a5f0eb88f_b11168549443--