Re: font-latex-make-title-faces using scaled font height rather than size

Ralf Angeli <[email protected]> writes:

> Thanks for looking at this.

My pleasure.

> I checked a change based on your findings into CVS.

That looks good, though we may wish to check that the regexp actually
matches. Consider something like:


  (string-to-number
   (progn
     (unless (string-match "^[0-9]+" base-size-string)
       (error "Unable to determine size for given face."))
     (match-string 0 base-size-string)))


I'm not sure why that would ever fail, but if it did, we'd wind up
with a 0[units] face. Maybe the attempt to create a face with size
0[units] would fail lower down anyway, but why not trap it here?

-- 
Steven E. Harris