Re: font-latex-make-title-faces using scaled font height rather than size

Ralf Angeli <[email protected]> Thu, 10 Mar 2005 18:08:45 +0100
Newsgroups gmane.emacs.auc-tex
Message-ID <[email protected]>
* Steven E. Harris (2005-03-10) writes:

>      (unless (string-match "^[0-9]+" base-size-string)
>        (error "Unable to determine size for given face."))
>      (match-string 0 base-size-string)))
>
> I'm not sure why that would ever fail, but if it did, we'd wind up
> with a 0[units] face. Maybe the attempt to create a face with size
> 0[units] would fail lower down anyway, but why not trap it here?

You won't get a face with height 0 because the call to `match-string'
will throw an error if there is no match.  Try

(progn (string-match "^[0-9]+" "xxx") (match-string 0 "xxx"))

And in case it fails it would probably be better to use a fallback
value instead of throwing an error.  But unless there is evidence that
this actually can happen I'd rather leave the code as is.

Thanks for the suggestion nevertheless.  I am really grateful for such
feedback, especially if it helps ironing out bugs which show up only
on XEmacs.

-- 
Ralf