bug#81223: [PATCH] Fix file-missing error during async native compilation

On 2026-08-08 03:10, Philip Kaludercic wrote:
> James Cherti <[email protected]> writes:
> 
>> On 2026-08-07 14:25, Philip Kaludercic wrote:
>>> James Cherti <[email protected]> writes:
>>>
>>>> Hello Sean and Phillip,
>>>>
>>>> Please don't make it difficult to contribute to Emacs.
>>>>
>>>> I would appreciate it if we focused on the core changes
>>>> rather than nitpicking.
>>>>
>>>> The latest patch already includes comments that are clear
>>>> enough and is ready to be merged.
>>> FWIW I just left a comment for you to know that whoever will merge
>>> this,
>>> would eventually point out that you were missing a bug number reference,
>>> and I wanted to save you the potential roundtrip.
>>
>> @Philip: Thanks Philip for clarifying that your comment was
>> intended to be informational, rather than a condition for
>> merging this patch.
>>
>> @Sean: I decline to make this change, as doing so would
>> encourage counterproductive behavior within the community.
>> The patch is ready to be merged. (Heavy nitpicking on small
>> details, especially for simple patches, makes contributors
>> hesitate before submitting future work.)
> 
> One thing I think is worth clarifying here, is that (IMO) when we ask
> you for a change, this is not meant to say "if you don't change this,
> this patch will never be merged", but "if you make this change, we don't
> have to do so ourselves, which would make it easier for us to merge it".
> The assumption is that since you are familiar with the code and your
> comments/commit message, it should be easier for you to make these
> changes and post the updated commit, rather than some maintainer or
> contributor to think about rephrasing.  This might not matter much in an
> individual case, but the effort saves accumulates over the scale of the
> project that makes a difference.
> 

Thanks for taking the time to explain. I'll keep that in
mind for future patch reviews.

> (Of course, if we continue discussing this then any time and effort
> saved will be lost again, so I hope that that won't be the case)
> 
>>>> On 2026-08-07 06:45, Sean Whitton wrote:
>>>>> James Cherti [06/Aug  7:20pm -04] wrote:
>>>>>> Subject: [PATCH] Fix file-missing error during async native compilation (bug#81223)
>>>>>>
>>>>>> The async native compilation queue can sometimes retain stale jobs for
>>>>>> files that no longer exist on disk (for example, when files are removed
>>>>>> during a package upgrade or deletion). Attempting to resolve the target
>>>>>> .eln filename for these missing files signals a file-missing error.
>>>>> Please remove this or move it into comments.  We prefer not to have
>>>>> extensive commentary in commit messages, see CONTRIBUTE.
>>>>>
>>>>>> * lisp/emacs-lisp/comp-run.el (comp--run-async-workers): Verify source
>>>>>> files exist before attempting to resolve their .eln paths in the
>>>>>> dispatch loop. In the process sentinel, wrap the compilation block in a
>>>>>> condition-case to catch file-missing errors and prevent the async worker
>>>>>> queue from stalling.
>>>>> Possibly this could be made shorter too, but it's less important.
>>>>>
>>>>
>>>> --
>>>> James Cherti
>>>> GitHub: https://github.com/jamescherti
>>>> Website: https://www.jamescherti.com/
>>>
>>
>> --
>> James Cherti
>> GitHub: https://github.com/jamescherti
>> Website: https://www.jamescherti.com/

--
James Cherti
GitHub: https://github.com/jamescherti
Website: https://www.jamescherti.com/