bug#81223: [PATCH] Fix file-missing error during async native compilation
James Cherti <[email protected]>
| Newsgroups | gmane.emacs.bugs |
|---|---|
| Message-ID | <[email protected]> |
On 2026-08-10 13:23, Philip Kaludercic wrote: > James Cherti <[email protected]> writes: > >> Hello Eli and Sean, >> >> This patch is ready on my end, so feel free to merge it. My >> commit message is not that long, and the code already >> includes explanatory comments. I have also added the bug >> number in the latest patch version. >> >> What I personally dislike is that the standards Sean asked >> me to follow are not applied equally to everyone and seem >> based on personal preference. (For example, there are many >> long git commit messages and several commits that do not >> adhere to the CONTRIBUTE file.) >> >> Manually enforcing a two-space rule or commit message length >> limits is tedious and consumes valuable review time for Sean >> and other maintainers. If these specific conventions are >> required, they should be handled automatically by a linter >> or formatter rather than human reviewers. > > Do you use checkdoc? IIRC if you use Flymake, checkdoc warnings (that > should include double-spacing of sentences) should be highlighted, but > after some time you just get so used to it as well that it hurts to see > single-spaced sentences -- or at least that was the case for me. > I use checkdoc, but it doesn't seem to display a warning when sentences in docstrings or comments aren't double-spaced. >> The way these small details are enforced right now is >> unfortunately inefficient and can cause friction. >> >> I recommend enforcing these minor formatting details through >> a pre-commit hook and a server-side check. This will ensure >> that the rules are applied consistently to all contributors, >> including maintainers. >> >> For contributors, this ensures that the pre-commit hook >> enforces these rules locally before a patch is submitted. >> This way, once a patch reaches the mailing list, reviewers >> can focus entirely on the code itself. > > > -- James Cherti GitHub: https://github.com/jamescherti Website: https://www.jamescherti.com/