Re: ECB Window management bug (Customize/EShell/VC-Log...)

finalpatch <[email protected]> writes:

> finalpatch <[email protected]> writes:
>
>> finalpatch <[email protected]> writes:
>> post. This is due to Emacs's 'pop-to-buffer' implies selecting that
>> buffer, but ECB's adviced version does do this, which causes all
>               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Sorry, should be 'does not do this'.

It's probably better to use 'set-buffer' here rather than
'switch-to-buffer' because 'switch-to-buffer' is also adviced by ECB
which might has unwanted side effects.

--- ecb-layout.el.~1.258.~	Thu May  8 22:03:44 2008
+++ ecb-layout.el	Tue Jan  6 14:35:43 2009
@@ -1707,6 +1707,7 @@
                                    (ad-get-arg 0) (ad-get-arg 1))
            (select-window (display-buffer (ad-get-arg 0)
                                           (ad-get-arg 1)))
+           (set-buffer (ad-get-arg 0))
            (if (ad-get-arg 2)
                ;; not the best solution but for now....
                (bury-buffer (ad-get-arg 0))))


-- 
finalpatch


------------------------------------------------------------------------------