Re: Slow filenotify-tests
Michael Albinus <[email protected]>
| Newsgroups | gmane.emacs.devel |
|---|---|
| Message-ID | <[email protected]> |
Eli Zaretskii <[email protected]> writes: Hi Eli, >> > Shouldn't the remote tests be marked as "expensive"? >> >> They are already. >> >> --8<---------------cut here---------------start------------->8--- >> make -C test filenotify-tests SELECTOR='$(SELECTOR_DEFAULT)' >> --8<---------------cut here---------------end--------------->8--- >> >> runs a restricted set of the tests only. > > I'm talking about the default. I just ran "filenotify-tests", without > any selectors. Shouldn't that by default avoid too-long tests? That was discussed years ago, when we have introduced the different SELECT_* variables in test/Makefile. The most common use case for 'make <filename>' is for developers, checking their package. It makes sense to run expensive tests in this case, so I don't like to change it. What we could think about is a configurable preference, which SELECTOR_* variable to apply for 'make <filename>' by default. A 'configure' option? Best regards, Michael.