Re: master d5f515e4a33 1/2: New image type canvas
Michael Albinus <[email protected]>
| Newsgroups | gmane.emacs.devel |
|---|---|
| Message-ID | <[email protected]> |
Divya Ranjan Pattanaik <[email protected]> writes: Hi Divya, > So you are right, we shouldn't be using display-graphic-p which is too strong, maybe instead (skip-unless (image-type-available-p 'canvas))? > > Using (skip-unless (image-type-available-p 'canvas)) would skip for Emba, but not for your build because the image type and the module function is still available when you use an Emacs built with GUI but used in TUI. This makes sense. We use (skip-unless (image-type-available-p ...)) in other test files as well, see for example lisp/image-file-tests.el, lisp/image-tests.el and lisp/image/image-dired-tests.el. > Patch with the above skip attached. Could you pls provide a commit message? I would push it to master then. > Regards, Best regards, Michael.