Re: Eglot tests fail on emba
Michael Albinus <[email protected]>
| Newsgroups | gmane.emacs.devel |
|---|---|
| Message-ID | <[email protected]> |
João Távora <[email protected]> writes: > Hi Michael, Hi João, > I've had a look at the log file and I can't make any sense of it either. > Given you say tests pass on emacs-31 branch, here's what I can say: > > * There haven't been any recent commits to Eglot. > > * The differences between emacs and emacs-31 versions of > lisp/progmodes/eglot.el cannot be responsible for this. All they do > is fix a docstring and change some versioning constants in defcustoms. > You can check yourself with git diff emacs-31..master lisp/progmodes/eglot.el > > * There are 0 differences in test/lisp/progmodes/eglot-tests.el > > * There are 0 differences for lisp/jsonrpc.el (a critical supporting library > for Eglot). I haven't said (and I didn't mean) that it is due to eglot.el changes. > So that said, I'm inclined to the following conjectures: > > * You were lucky/unlucky: the tests are instable in both versions and things > just happened to go sour on master, not on emacs-31 > > * Some different fixture setup (different rust-analyzer version) on master > and emacs-31 runs. > > * Some underlying child process bookkeeping machinery has subtly changed > recently. Last change to src/process.c is from June though (and you authored it) > and looks innocent enough. > > So, maybe someone can shed some light. I can't; not at the moment > at least. I have no idea where to look, as I'm a n00b wrt eglot. Is there somebody else, who coulkd track what happens? The messages don't tell me anything. > João Best regards, Michael.