Re: Eglot tests fail on emba

Michael Albinus <[email protected]> writes:

>> * There are 0 differences in test/lisp/progmodes/eglot-tests.el
>>
>> * There are 0 differences for lisp/jsonrpc.el (a critical supporting library
>> for Eglot).
>
> I haven't said (and I didn't mean) that it is due to eglot.el changes.

Of course, but it is nevertheless reasonably useful information for this
analysis (don't you think?) so I provided it :-)

>> So, maybe someone can shed some light. I can't; not at the moment
>> at least.
>
> I have no idea where to look, as I'm a n00b wrt eglot. Is there somebody
> else, who coulkd track what happens? The messages don't tell me
> anything.

I could reproduce it (or at least some gross deviation) locally, so I
bisected it with this canary 

   make -C test eglot-tests SELECTOR='"pull-diagnostics"'

This needs the 'ty' server, should be easy to install with pip or
whatever package manager you like.

On master this hangs, on emacs-31 it doesn't.  Please have a look at
what you may have (subtly) changed in the externally observable behavior
of filenotify.el around two days ago.

João

07925d707000288e933ea8239e8c3c7189efb899 is the first 'bad' commit
commit 07925d707000288e933ea8239e8c3c7189efb899
Author: Michael Albinus <[email protected]>
Date:   Fri Aug 21 09:42:00 2026 +0200

    Improve handling of pending `renamed' event in filenotify.el

    * lisp/filenotify.el (file-notify--rm-descriptor): Remove.
    (file-notify--expand-file-name): Use `file-local-name'.
    (file-notify--callback-inotify, file-notify--callback-kqueue)
    (file-notify--callback-w32notify)
    (file-notify--callback-gfilenotify, file-notify-callback): Map
    also `stopped' event.
    (file-notify--call-handler): Handle also `stopped' event.
    (file-notify--handle-event): Improve handling of pending `renamed'
    event.  (Bug#81531)
    (file-notify-rm-watch): Integrate code of removed
    `file-notify--rm-descriptor'.

    * test/lisp/filenotify-tests.el (file-notify--test-tmpdir1): Declare.
    (file-notify--test-event-test): Better check for `stopped' events.
    (file-notify-test03-events, file-notify-test05-file-validity)
    (file-notify-test06-dir-validity)
    (file-notify-test07-many-events, file-notify-test08-backup)
    (file-notify-test09-watched-file-in-watched-dir): Adapt tests.
    (file-notify-test10-move-file-to-another-watched-dir): New test.
    (file-notify-test11-sufficient-resources)
    (file-notify-test12-symlinks): Rename tests.

 lisp/filenotify.el            | 182 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------------------------------------------------
 test/lisp/filenotify-tests.el | 174 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------
 2 files changed, 224 insertions(+), 132 deletions(-)