Re: Contributing to ScummVM with an interpreter for Magnetic Scrolls?

--===============5425018857639758524==
Content-Type: multipart/alternative; boundary="00000000000079d55f05883f6c15"

--00000000000079d55f05883f6c15
Content-Type: text/plain; charset="UTF-8"

On Mon, 6 May 2019 at 08:09, dettus <[email protected]> wrote:

> ONE MORE QUESTION THOUGH:
>
> 4) What is the policy with rookie developers like me, in general? Should I
> just clone code from the git repository, commit/push/pull my changes? Or do
> you guys create a branch? And merge the code over after a reviewing process
> or something?
>

You work in a separate branch, and when you feel that your code is mature
enough, create a pull request, so that your code can get reviewed and merged

Regards
Filippos

-- 
"Experience is the name every one gives to their mistakes" - Oscar Wilde

--00000000000079d55f05883f6c15
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div><br></div><div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=
=3D"gmail_attr">On Mon, 6 May 2019 at 08:09, dettus &lt;<a href=3D"mailto:d=
[email protected]">[email protected]</a>&gt; wrote:<br></div><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;pa=
dding-left:1ex">
 =20
   =20
 =20
  <div text=3D"#000000" bgcolor=3D"#FFFFFF">
    <p>ONE MORE QUESTION THOUGH:<br></p>
    <p>4) What is the policy with rookie developers like me, in general?
      Should I just clone code from the git repository, commit/push/pull
      my changes? Or do you guys create a branch? And merge the code
      over after a reviewing process or something?</p></div></blockquote><d=
iv dir=3D"auto"><br></div><div dir=3D"auto">You work in a separate branch, =
and when you feel that your code is mature enough, create a pull request, s=
o that your code can get reviewed and merged</div><div dir=3D"auto"><br></d=
iv><div dir=3D"auto">Regards</div><div dir=3D"auto">Filippos</div><div dir=
=3D"auto"><br></div></div></div>-- <br><div dir=3D"ltr" class=3D"gmail_sign=
ature" data-smartmail=3D"gmail_signature">&quot;Experience is the name ever=
y one gives to their mistakes&quot; - Oscar Wilde </div>

--00000000000079d55f05883f6c15--


--===============5425018857639758524==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KU2N1bW12bS1k
ZXZlbCBtYWlsaW5nIGxpc3QKU2N1bW12bS1kZXZlbEBsaXN0cy5zY3VtbXZtLm9yZwpodHRwczov
L2xpc3RzLnNjdW1tdm0ub3JnL2xpc3RpbmZvL3NjdW1tdm0tZGV2ZWwK

--===============5425018857639758524==--