Re: Contributing to ScummVM with an interpreter for Magnetic Scrolls?

--===============7411278203506186872==
Content-Type: multipart/alternative; boundary="00000000000045d1c405884666fd"

--00000000000045d1c405884666fd
Content-Type: text/plain; charset="UTF-8"

As Filippos mentioned, you create our own branch and work on that. As you
requested, to get you going, I've created a new branch at
http://github.com/dreammaster/scummvm.git called "magnetic". If you make
your own branch for it, you'll find it already has detection entries added
into it for the games, and everything hooked up and ready to go to call the
runGame() method. Have at it. :)

Paul.

On Tue, May 7, 2019 at 8:14 AM Filippos Karapetis <[email protected]> wrote:

>
>
> On Mon, 6 May 2019 at 08:09, dettus <[email protected]> wrote:
>
>> ONE MORE QUESTION THOUGH:
>>
>> 4) What is the policy with rookie developers like me, in general? Should
>> I just clone code from the git repository, commit/push/pull my changes? Or
>> do you guys create a branch? And merge the code over after a reviewing
>> process or something?
>>
>
> You work in a separate branch, and when you feel that your code is mature
> enough, create a pull request, so that your code can get reviewed and merged
>
> Regards
> Filippos
>
> --
> "Experience is the name every one gives to their mistakes" - Oscar Wilde
> _______________________________________________
> Scummvm-devel mailing list
> [email protected]
> https://lists.scummvm.org/listinfo/scummvm-devel
>

--00000000000045d1c405884666fd
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">As Filippos mentioned, you create our own branch and work =
on that. As you requested, to get you going, I&#39;ve created a new branch =
at <a href=3D"http://github.com/dreammaster/scummvm.git">http://github.com/=
dreammaster/scummvm.git</a> called &quot;magnetic&quot;. If you make your o=
wn branch for it, you&#39;ll find it already has detection entries added in=
to it for the games, and everything hooked up and ready to go to call the r=
unGame() method. Have at it. :)<div><br></div><div>Paul.</div></div><br><di=
v class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, May 7=
, 2019 at 8:14 AM Filippos Karapetis &lt;<a href=3D"mailto:[email protected]=
">[email protected]</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote=
" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);=
padding-left:1ex"><div><br></div><div><br><div class=3D"gmail_quote"><div d=
ir=3D"ltr" class=3D"gmail_attr">On Mon, 6 May 2019 at 08:09, dettus &lt;<a =
href=3D"mailto:[email protected]" target=3D"_blank">[email protected]</a>&g=
t; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0p=
x 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
 =20
   =20
 =20
  <div bgcolor=3D"#FFFFFF">
    <p>ONE MORE QUESTION THOUGH:<br></p>
    <p>4) What is the policy with rookie developers like me, in general?
      Should I just clone code from the git repository, commit/push/pull
      my changes? Or do you guys create a branch? And merge the code
      over after a reviewing process or something?</p></div></blockquote><d=
iv dir=3D"auto"><br></div><div dir=3D"auto">You work in a separate branch, =
and when you feel that your code is mature enough, create a pull request, s=
o that your code can get reviewed and merged</div><div dir=3D"auto"><br></d=
iv><div dir=3D"auto">Regards</div><div dir=3D"auto">Filippos</div><div dir=
=3D"auto"><br></div></div></div>-- <br><div dir=3D"ltr" class=3D"gmail-m_-4=
558293230750501553gmail_signature">&quot;Experience is the name every one g=
ives to their mistakes&quot; - Oscar Wilde </div>
_______________________________________________<br>
Scummvm-devel mailing list<br>
<a href=3D"mailto:[email protected]" target=3D"_blank">Scummv=
[email protected]</a><br>
<a href=3D"https://lists.scummvm.org/listinfo/scummvm-devel" rel=3D"norefer=
rer" target=3D"_blank">https://lists.scummvm.org/listinfo/scummvm-devel</a>=
<br>
</blockquote></div>

--00000000000045d1c405884666fd--


--===============7411278203506186872==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KU2N1bW12bS1k
ZXZlbCBtYWlsaW5nIGxpc3QKU2N1bW12bS1kZXZlbEBsaXN0cy5zY3VtbXZtLm9yZwpodHRwczov
L2xpc3RzLnNjdW1tdm0ub3JnL2xpc3RpbmZvL3NjdW1tdm0tZGV2ZWwK

--===============7411278203506186872==--