Re: Contributing to ScummVM with an interpreter for Magnetic Scrolls?
Paul Gilbert <[email protected]> Tue, 7 May 2019 16:39:41 +1000
| Newsgroups | gmane.games.devel.scummvm |
|---|---|
| Message-ID | <CAEkg9RMT5ftb9VoJMEosHe47+GeTrpUd97gB6R8D3FC6p1cWFQ@mail.gmail.com> |
--===============7570774567452479395== Content-Type: multipart/alternative; boundary="000000000000bc0e440588467c7b" --000000000000bc0e440588467c7b Content-Type: text/plain; charset="UTF-8" Oh, and I've made it a new sub-folder "magnetic2", and likewise a "Magnetic2" namespace to differentiate it from the work already done on the existing Magnetic sub-engine for Gargoyle. Paul. On Tue, May 7, 2019 at 4:33 PM Paul Gilbert <[email protected]> wrote: > As Filippos mentioned, you create our own branch and work on that. As you > requested, to get you going, I've created a new branch at > http://github.com/dreammaster/scummvm.git called "magnetic". If you make > your own branch for it, you'll find it already has detection entries added > into it for the games, and everything hooked up and ready to go to call the > runGame() method. Have at it. :) > > Paul. > > On Tue, May 7, 2019 at 8:14 AM Filippos Karapetis <[email protected]> > wrote: > >> >> >> On Mon, 6 May 2019 at 08:09, dettus <[email protected]> wrote: >> >>> ONE MORE QUESTION THOUGH: >>> >>> 4) What is the policy with rookie developers like me, in general? Should >>> I just clone code from the git repository, commit/push/pull my changes? Or >>> do you guys create a branch? And merge the code over after a reviewing >>> process or something? >>> >> >> You work in a separate branch, and when you feel that your code is mature >> enough, create a pull request, so that your code can get reviewed and merged >> >> Regards >> Filippos >> >> -- >> "Experience is the name every one gives to their mistakes" - Oscar Wilde >> _______________________________________________ >> Scummvm-devel mailing list >> [email protected] >> https://lists.scummvm.org/listinfo/scummvm-devel >> > --000000000000bc0e440588467c7b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Oh, and I've made it a new sub-folder "magnetic2&= quot;, and likewise a "Magnetic2" namespace to differentiate it f= rom the work already done on the existing Magnetic sub-engine for Gargoyle.= <div><br></div><div>Paul.</div></div><br><div class=3D"gmail_quote"><div di= r=3D"ltr" class=3D"gmail_attr">On Tue, May 7, 2019 at 4:33 PM Paul Gilbert = <<a href=3D"mailto:[email protected]">[email protected]</a>>= ; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px= 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div di= r=3D"ltr">As Filippos mentioned, you create our own branch and work on that= . As you requested, to get you going, I've created a new branch at <a h= ref=3D"http://github.com/dreammaster/scummvm.git" target=3D"_blank">http://= github.com/dreammaster/scummvm.git</a> called "magnetic". If you = make your own branch for it, you'll find it already has detection entri= es added into it for the games, and everything hooked up and ready to go to= call the runGame() method. Have at it. :)<div><br></div><div>Paul.</div></= div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On= Tue, May 7, 2019 at 8:14 AM Filippos Karapetis <<a href=3D"mailto:blueg= [email protected]" target=3D"_blank">[email protected]</a>> wrote:<br></div><bl= ockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-lef= t:1px solid rgb(204,204,204);padding-left:1ex"><div><br></div><div><br><div= class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, 6 May = 2019 at 08:09, dettus <<a href=3D"mailto:[email protected]" target=3D"_b= lank">[email protected]</a>> wrote:<br></div><blockquote class=3D"gmail_= quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,= 204);padding-left:1ex"> =20 =20 =20 <div bgcolor=3D"#FFFFFF"> <p>ONE MORE QUESTION THOUGH:<br></p> <p>4) What is the policy with rookie developers like me, in general? Should I just clone code from the git repository, commit/push/pull my changes? Or do you guys create a branch? And merge the code over after a reviewing process or something?</p></div></blockquote><d= iv dir=3D"auto"><br></div><div dir=3D"auto">You work in a separate branch, = and when you feel that your code is mature enough, create a pull request, s= o that your code can get reviewed and merged</div><div dir=3D"auto"><br></d= iv><div dir=3D"auto">Regards</div><div dir=3D"auto">Filippos</div><div dir= =3D"auto"><br></div></div></div>-- <br><div dir=3D"ltr" class=3D"gmail-m_86= 68754604151963312gmail-m_-4558293230750501553gmail_signature">"Experie= nce is the name every one gives to their mistakes" - Oscar Wilde </div= > _______________________________________________<br> Scummvm-devel mailing list<br> <a href=3D"mailto:[email protected]" target=3D"_blank">Scummv= [email protected]</a><br> <a href=3D"https://lists.scummvm.org/listinfo/scummvm-devel" rel=3D"norefer= rer" target=3D"_blank">https://lists.scummvm.org/listinfo/scummvm-devel</a>= <br> </blockquote></div> </blockquote></div> --000000000000bc0e440588467c7b-- --===============7570774567452479395== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KU2N1bW12bS1k ZXZlbCBtYWlsaW5nIGxpc3QKU2N1bW12bS1kZXZlbEBsaXN0cy5zY3VtbXZtLm9yZwpodHRwczov L2xpc3RzLnNjdW1tdm0ub3JnL2xpc3RpbmZvL3NjdW1tdm0tZGV2ZWwK --===============7570774567452479395==--