Re: Contributing to ScummVM with an interpreter for Magnetic Scrolls?
dettus <[email protected]> Wed, 8 May 2019 09:44:17 +0200
| Newsgroups | gmane.games.devel.scummvm |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format. --===============8746691897772554110== Content-Type: multipart/alternative; boundary="------------0C9E13ED41BCB5799BFB2930" Content-Language: en-US This is a multi-part message in MIME format. --------------0C9E13ED41BCB5799BFB2930 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit "Game is Open" "Oh! And the Graphics File is present To" :) Thank you Paul! Thomas On 5/7/19 8:39 AM, Paul Gilbert wrote: > Oh, and I've made it a new sub-folder "magnetic2", and likewise a > "Magnetic2" namespace to differentiate it from the work already done > on the existing Magnetic sub-engine for Gargoyle. > > Paul. > > On Tue, May 7, 2019 at 4:33 PM Paul Gilbert <[email protected] > <mailto:[email protected]>> wrote: > > As Filippos mentioned, you create our own branch and work on that. > As you requested, to get you going, I've created a new branch at > http://github.com/dreammaster/scummvm.git called "magnetic". If > you make your own branch for it, you'll find it already has > detection entries added into it for the games, and everything > hooked up and ready to go to call the runGame() method. Have at > it. :) > > Paul. > > On Tue, May 7, 2019 at 8:14 AM Filippos Karapetis > <[email protected] <mailto:[email protected]>> wrote: > > > > On Mon, 6 May 2019 at 08:09, dettus <[email protected] > <mailto:[email protected]>> wrote: > > ONE MORE QUESTION THOUGH: > > 4) What is the policy with rookie developers like me, in > general? Should I just clone code from the git repository, > commit/push/pull my changes? Or do you guys create a > branch? And merge the code over after a reviewing process > or something? > > > You work in a separate branch, and when you feel that your > code is mature enough, create a pull request, so that your > code can get reviewed and merged > > Regards > Filippos > > -- > "Experience is the name every one gives to their mistakes" - > Oscar Wilde > _______________________________________________ > Scummvm-devel mailing list > [email protected] > <mailto:[email protected]> > https://lists.scummvm.org/listinfo/scummvm-devel > > > _______________________________________________ > Scummvm-devel mailing list > [email protected] > https://lists.scummvm.org/listinfo/scummvm-devel --------------0C9E13ED41BCB5799BFB2930 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> <p>"Game is Open" "Oh! And the Graphics File is present To" :)</p> <p><br> </p> <p>Thank you Paul!</p> <p><br> </p> <p>Thomas</p> <p><br> </p> <div class="moz-cite-prefix">On 5/7/19 8:39 AM, Paul Gilbert wrote:<br> </div> <blockquote type="cite" cite="mid:CAEkg9RMT5ftb9VoJMEosHe47+GeTrpUd97gB6R8D3FC6p1cWFQ@mail.gmail.com"> <meta http-equiv="content-type" content="text/html; charset=UTF-8"> <div dir="ltr">Oh, and I've made it a new sub-folder "magnetic2", and likewise a "Magnetic2" namespace to differentiate it from the work already done on the existing Magnetic sub-engine for Gargoyle. <div><br> </div> <div>Paul.</div> </div> <br> <div class="gmail_quote"> <div dir="ltr" class="gmail_attr">On Tue, May 7, 2019 at 4:33 PM Paul Gilbert <<a href="mailto:[email protected]" moz-do-not-send="true">[email protected]</a>> wrote:<br> </div> <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <div dir="ltr">As Filippos mentioned, you create our own branch and work on that. As you requested, to get you going, I've created a new branch at <a href="http://github.com/dreammaster/scummvm.git" target="_blank" moz-do-not-send="true">http://github.com/dreammaster/scummvm.git</a> called "magnetic". If you make your own branch for it, you'll find it already has detection entries added into it for the games, and everything hooked up and ready to go to call the runGame() method. Have at it. :) <div><br> </div> <div>Paul.</div> </div> <br> <div class="gmail_quote"> <div dir="ltr" class="gmail_attr">On Tue, May 7, 2019 at 8:14 AM Filippos Karapetis <<a href="mailto:[email protected]" target="_blank" moz-do-not-send="true">[email protected]</a>> wrote:<br> </div> <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <div><br> </div> <div><br> <div class="gmail_quote"> <div dir="ltr" class="gmail_attr">On Mon, 6 May 2019 at 08:09, dettus <<a href="mailto:[email protected]" target="_blank" moz-do-not-send="true">[email protected]</a>> wrote:<br> </div> <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <div bgcolor="#FFFFFF"> <p>ONE MORE QUESTION THOUGH:<br> </p> <p>4) What is the policy with rookie developers like me, in general? Should I just clone code from the git repository, commit/push/pull my changes? Or do you guys create a branch? And merge the code over after a reviewing process or something?</p> </div> </blockquote> <div dir="auto"><br> </div> <div dir="auto">You work in a separate branch, and when you feel that your code is mature enough, create a pull request, so that your code can get reviewed and merged</div> <div dir="auto"><br> </div> <div dir="auto">Regards</div> <div dir="auto">Filippos</div> <div dir="auto"><br> </div> </div> </div> -- <br> <div dir="ltr" class="gmail-m_8668754604151963312gmail-m_-4558293230750501553gmail_signature">"Experience is the name every one gives to their mistakes" - Oscar Wilde </div> _______________________________________________<br> Scummvm-devel mailing list<br> <a href="mailto:[email protected]" target="_blank" moz-do-not-send="true">[email protected]</a><br> <a href="https://lists.scummvm.org/listinfo/scummvm-devel" rel="noreferrer" target="_blank" moz-do-not-send="true">https://lists.scummvm.org/listinfo/scummvm-devel</a><br> </blockquote> </div> </blockquote> </div> <br> <fieldset class="mimeAttachmentHeader"></fieldset> <pre class="moz-quote-pre" wrap="">_______________________________________________ Scummvm-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:[email protected]">[email protected]</a> <a class="moz-txt-link-freetext" href="https://lists.scummvm.org/listinfo/scummvm-devel">https://lists.scummvm.org/listinfo/scummvm-devel</a> </pre> </blockquote> </body> </html> --------------0C9E13ED41BCB5799BFB2930-- --===============8746691897772554110== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KU2N1bW12bS1k ZXZlbCBtYWlsaW5nIGxpc3QKU2N1bW12bS1kZXZlbEBsaXN0cy5zY3VtbXZtLm9yZwpodHRwczov L2xpc3RzLnNjdW1tdm0ub3JnL2xpc3RpbmZvL3NjdW1tdm0tZGV2ZWwK --===============8746691897772554110==--