Re: [Freeciv-Dev] (PR#10021) infinite loop in autosettlers?

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10021 >

Jason Short wrote:

> This looks like a simple logical error in auto_settler_findwork.  It
> starts out trying to build a city, but can't.  So then it looks at the
> fallback.  There are no improvements to be done so it tries to build a
> city again, and the funtion recurses.

  Was this with or wothout this commit:
Date : 2004/9/10 21:20:53
Author : 'jdorje'

...

- Move the is_ascii_name check into is_allowed_player_name and
   is_allowed_city_name.  This means that the server will not suggest a
   name that cannot be used.
- Allow a name taken from the ruleset to be used, even if is_ascii_name
   won't pass it.

...


  I guess that it was possible that city_name_suggestion() always 
returned illegal name (player had only illegal ones left but no 
fallbacks were used) and handle_unit_build_city() failed because of this.


  - Caz