Re: (PR#11009) AI Hunts Own Units

<URL: http://rt.freeciv.org/Ticket/Display.html?id=11009 >

On Tue, 16 Nov 2004, Benedict Adamson wrote:

>
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=11009 >
>
> Gregory Berkolaiko wrote:
> ...
> > This patch is a band-aid.  The real problem is that is_player_dangerous
> > seems to return TRUE on self (according to the bug report).  This
> > shouldn't happen.  Please investigate why does it happen and fix it there.
> ...
>
> Attached is a better fix, with comments indicating some of the related
> peculiarities.

The comments are good, the fix is not much better, since you just shift
the band aid to a different place.  We have to know which one of the
conditions is actually malfunctioning.

Jason: the first patch is probably better of the two for S2_0, because
it's more localized.  But I would like to get to the heart of the problem
too (although the real fix might be unsuitable for S2_0).

Best wishes,
Gr