review comments on draft-ietf-adslmib-gshdslbis-02.txt

Hi -

Here are my MIB reviewer comments on draft-ietf-adslmib-gshdslbis-02.txt,
based on compilation and smidiff checks.
This message identifies one serious problem, marked ***,
on minor problem, marked **,
and some editorial details.

Running smilint identified no errors.

Running smidiff to evaluate the changes with respect to
rfc3276 produced several diagnostics.  The ones
that warrent comment are:

  new:20 contact of `HDSL2-SHDSL-LINE-MIB' changed
      ok, but review guidelines section 4.5 say that
      the contact-info should also include a pointer
      to the working group's web page.

  rfc3276:49 revision `2002-05-09 00:00' removed
  new:55 revision `2004-06-17 00:00' added
  new:70 revision `2004-06-07 00:00' added
      ** the original publication REVISION (2002-05-09) needs
      to be retained.  the others will need to be collapsed
      into a single one when it is time to hand this to the
      rfc editor.

  new:113 format added to `Hdsl2ShdslPerfCurrDayCount'
  new:132 format added to `Hdsl2Shdsl1DayIntervalCount'
  new:148 format added to `Hdsl2ShdslPerfTimeElapsed'
  new:160 format added to `Hdsl2ShdslPerfIntervalThreshold'
        ok.

  new:200 named number `wirePair3' added to type `Hdsl2ShdslWirePair'
  new:200 named number `wirePair4' added to type `Hdsl2ShdslWirePair'
  new:200 description of `Hdsl2ShdslWirePair' changed
  rfc3276:138 previous definition of `Hdsl2ShdslWirePair'
        ok.

  new:358 type `Unsigned32' replaces implicit type for `hdsl2ShdslStatusMaxAttainableLineRate'
  rfc3276:288 previous definition of `hdsl2ShdslStatusMaxAttainableLineRate'
  new:358 range `(0..4112000)' removed from type used in `hdsl2ShdslStatusMaxAttainableLineRate'
  rfc3276:288 previous definition of `hdsl2ShdslStatusMaxAttainableLineRate'
  new:358 description of `hdsl2ShdslStatusMaxAttainableLineRate' changed
  rfc3276:288 previous definition of `hdsl2ShdslStatusMaxAttainableLineRate'
        ok with me, though some might prefer (0..4294967295)

  new:370 type `Unsigned32' replaces implicit type for `hdsl2ShdslStatusActualLineRate'
  rfc3276:299 previous definition of `hdsl2ShdslStatusActualLineRate'
  new:370 range `(0..4112000)' removed from type used in `hdsl2ShdslStatusActualLineRate'
  rfc3276:299 previous definition of `hdsl2ShdslStatusActualLineRate'
  new:370 description of `hdsl2ShdslStatusActualLineRate' changed
  rfc3276:299 previous definition of `hdsl2ShdslStatusActualLineRate'
        ok with me, though some might prefer (0..4294967295)

  new:593 named number `wirePair3' added to type used in `hdsl2ShdslEndpointWirePair'
  new:593 named number `wirePair4' added to type used in `hdsl2ShdslEndpointWirePair'
        ok.

  new:1324 named number `sixWire' added to type used in `hdsl2ShdslSpanConfWireInterface'
  new:1324 named number `eightWire' added to type used in `hdsl2ShdslSpanConfWireInterface'
  new:1324 description of `hdsl2ShdslSpanConfWireInterface' changed
  rfc3276:1202 previous definition of `hdsl2ShdslSpanConfWireInterface'
        ok.

  new:1339 type `Unsigned32' replaces implicit type for `hdsl2ShdslSpanConfMinLineRate'
  rfc3276:1215 previous definition of `hdsl2ShdslSpanConfMinLineRate'
  new:1339 range `(0..4112000)' removed from type used in `hdsl2ShdslSpanConfMinLineRate'
  rfc3276:1215 previous definition of `hdsl2ShdslSpanConfMinLineRate'
  new:1339 description of `hdsl2ShdslSpanConfMinLineRate' changed
  rfc3276:1215 previous definition of `hdsl2ShdslSpanConfMinLineRate'
        ok.

  new:1355 type `Unsigned32' replaces implicit type for `hdsl2ShdslSpanConfMaxLineRate'
  rfc3276:1229 previous definition of `hdsl2ShdslSpanConfMaxLineRate'
  new:1355 range `(0..4112000)' removed from type used in `hdsl2ShdslSpanConfMaxLineRate'
  rfc3276:1229 previous definition of `hdsl2ShdslSpanConfMaxLineRate'
  new:1355 description of `hdsl2ShdslSpanConfMaxLineRate' changed
  rfc3276:1229 previous definition of `hdsl2ShdslSpanConfMaxLineRate'
        ok.

  new:388 column `hdsl2ShdslStatusMaxAttainablePayloadRate' has been added
  new:400 column `hdsl2ShdslStatusActualPayloadRate' has been added
  new:917 column `hdsl2ShdslEndpointCurrTipRingReversal' has been added
  new:929 column `hdsl2ShdslEndpointCurrActivationState' has been added
        ok.

  new:1990 member `hdsl2ShdslStatusMaxAttainablePayloadRate' added to group `hdsl2ShdslSpanShdslStatusGroup'
  new:1990 member `hdsl2ShdslStatusActualPayloadRate' added to group `hdsl2ShdslSpanShdslStatusGroup'
        *** NOT OK.  See RFC 2580 clause 7.1,
        and MIB review guidelines top of page 30.

  new:2178 group `hdsl2ShdslCurrShdslGroup' has been added
        ok, but the DESCRIPTION of hdsl2ShdslCurrShdslGroup is not too
        clear about what "current" refers to.


I'll send in any comments on the rest of the document separately.

Randy