Re: [IPFIX] AD review: draft-trammell-ipfix-tcpcontrolbits-revision-03
Benoit Claise <[email protected]>
| Newsgroups | gmane.ietf.ipfix |
|---|---|
| Message-ID | <[email protected]> |
Hi Brian, > hi Benoit, > > Thanks; comments inline... > > On 7 Oct 2013, at 14:24 , Benoit Claise <[email protected]> wrote: > >> Dear all, >> >> I accepted to AD sponsor this document. >> >> Here is my review. >> >> Do we need to say "update RFC 5102"? Not sure myself. >> On one side, we update an IE specified in RFC 5102 >> On the other side, RFC 7012 says that the registry is THE reference. > Given that, there's no need to update 5102; I've changed the abstract to make this a bit more clear: > > This document revises the tcpControlBits IPFIX Information Element as originally defined in > [RFC5102] to reflect changes to the TCP Flags header field since [RFC0793]. > ^^ > added "as originally defined" to make it clear that 5102 is the source, not the authority. > > The change does replace revision 0 of the IE in the registry with revision 1 "The change does replace revision 0 of the IE in the registry with revision 1" does the job for me. > ; I'll change the IANA Considerations section to make this more explicit, too. Ok; > >> Personally, I would have gone with the update path. >> Anyway, not a blocking factor to progress the document. I will check with IANA. >> >> OLD: >> >> IANA will update the definition of the tcpControlBits Information >> Element in the the IANA IPFIX Information Element Registry >> [IANA-IPFIX] to reflect the changes in Section 2 above. >> >> NEW: >> >> IANA updates the definition of the tcpControlBits Information >> Element in the the IANA IPFIX Information Element Registry >> [IANA-IPFIX] to reflect the changes in Section 2 above. > Changed to past-tense instead. good. > >> There are a couple of nits, specifically because RFC 7011, 7012, 7013 have been published. > Fixed the references. > >> Please post a new version, and I'll progress the document. > Will do shortly. Great. I'll progress the document from there. Regards, Benoit > > Cheers, > > Brian _______________________________________________ IPFIX mailing list [email protected] https://www.ietf.org/mailman/listinfo/ipfix