Re: [IPFIX] Review of draft-irtf-nmrg-location-ipfix-07.txt

--===============8576216978816366276==
Content-Type: multipart/signed;
 boundary="Apple-Mail=_D518C538-25C7-43AF-89E1-8A92D629B949";
 protocol="application/pgp-signature"; micalg=pgp-sha512


--Apple-Mail=_D518C538-25C7-43AF-89E1-8A92D629B949
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Ok, more clear now.
So, we work on a new text to resolve ALL the raised issues and send you =
a version.

Best,
> On 03 Mar 2017, at 12:07, PJ Aitken <[email protected]> wrote:
>=20
> Abdelkader, it was me who did the IE-doctors review. That's only =
concerned with the IANA request; it's not an IPFIX review of the =
document.
>=20
> P.
>=20
>=20
> On 03/03/17 11:01, Abdelkader Lahmadi wrote:
>> Hello,
>> We haven=E2=80=99t really get a "proper review" of the document by =
IPFIX experts. Recently, we had a discussion with IANA and they asked =
IE-doctors to make a review, since that we received some points to be =
fixed regarding the proposed IE. I can forward to you the other comments =
from IE-doctors that we have received by IANA.
>>=20
>> Thank you for your comments, Ok we will fix the raised issues in the =
document.
>> Best regards.
>>=20
>>=20
>>> On 03 Mar 2017, at 11:42, PJ Aitken <[email protected]> wrote:
>>>=20
>>> Authors, has this document been reviewed by any IPFIX experts?
>>>=20
>>> I see a request on November 23rd, but no reviews. So let me sign up =
for that.
>>>=20
>>>=20
>>> First, I took a quick look at the Figures in Appendix B:
>>>=20
>>> Figure 1: the Field Count should be 5, not 2.
>>>=20
>>> Figure 2: the size of the optional Padding field is wrong: the =
figure shows 9 bits rather than 8.
>>>=20
>>> Figure 4: the Length of 32 should be 28. The =
"geospatialLocationPosLat" Information Element isn't defined.
>>>=20
>>> Figure 5: the Field Count of 2 should be 3.
>>>=20
>>> Figure 7: The "geospatialLocationPostLng" and =
"geospatialLocationtLng" Information Elements aren't defined.
>>>=20
>>> Figure 9: The sizes of the "CivicValue" data fields are not shown =
correctly. eg, "Inria Nancy-Grand Est" is depicted in 6 octets when it =
should contain 21. Therefore the Figure is misleading and difficult to =
understand; it is not a good example. Please redraw the figure =
correctly. Please mark the variable-lengths eg "vlen =3D 21".
>>>=20
>>> Figure 11:
>>>    The Set IDs (311, 312, 313) do not correspond to the Template IDs =
in Figure 10 (306, 307, 308).
>>>    Again, the "Inria Nancy-Grand Grand Est" field is depicted in 6 =
octets rather than the requisite 27. Without the repeated "Grand", the =
21 would be correct. Please write "vlen=3D21"
>>>    The "Civic location Attr length" of 25 seems wrong.
>>>=20
>>>=20
>>> This document is not ready for publication. Please post an updated =
version so I can check that all the IPFIX details are correct.
>>>=20
>>> Thanks,
>>> P.
>=20
> _______________________________________________
> IPFIX mailing list
> [email protected]
> https://www.ietf.org/mailman/listinfo/ipfix


--Apple-Mail=_D518C538-25C7-43AF-89E1-8A92D629B949
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQIcBAEBCgAGBQJYuVDkAAoJEBX1Mi7AAzI66WIQAKHCI8ngHskuBBJkJR42VUFO
uFhzEWE+roZz0KR6Z320gz7I7zgJGiu0FzZDiuCAp5fwgsYnU6Qpp9H+ODto3t7P
ejJ55DKDkAJQasr4HZQFZenD4UyxWaeLAMRgr2PBCK+KCkVoxrArqPd/mfsQ76sp
OklMivb/wKk8T5MsDB+KKdCvbMbTAY4XdBI9IsymtaqfNSdPSgorHIJTCI9ndRRG
jM/gJEvF5nLfegYIKULmwYyINZbORUt0xIPUG2McfFcpSLEkpxNW3ZyIruQg/LiW
p5B9V0OOUPH8n7q/YlQg+JWUh0DCdiLBg0JAPuIAIEBHkDwLfIZnWCYRA59G3phP
UFdfYI8/f1eDT16mC9Mu2s5Den/TdpS/EqBlX/wSjDseG90Cgz366+Ke1Zdt/ir9
RQGu3ZVJG+ioLtNsuNzfBXqUS0GDqH6FA+Fx2ox1+jJuAgBe7t0LXUuxocZGL5Xd
PYpOJMjDnMST9dA2CXhOcRIaRXgSK+PndXQ/Q7T7PvGWYJo/FHwUwPP68swFkjET
7qXxE+/csxQRlhDY8+Ag/GoUpiOTMZXWKD2+nlDy7m479OIwZAujF6uugzeOnTVc
ntyDKlq/A4R4mwHUZLzjaoWOlkuDQVwT38ohiwetBPX6ea6oLU81NHlhmnX5hUAw
LYFR4VDBYFxNzhYua3F9
=X1dz
-----END PGP SIGNATURE-----

--Apple-Mail=_D518C538-25C7-43AF-89E1-8A92D629B949--


--===============8576216978816366276==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
IPFIX mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/ipfix

--===============8576216978816366276==--